fix(github-app): address Henry's review — source guard, consistent paths, symlink fix, README notes

Author: jack-nsheaps[bot]

plugins/github-app/README.md

@@ -191,6 +191,29 @@ plugins/github-app/
 └── README.md
 ```
 
+## Upgrading from 0.1.x
+
+### Migration
+
+v0.2.0 moves credential storage from `~/.config/agent/` to `~/.agents/${AGENT_NAME}/.config/`. On first session start after upgrading, a fresh token is generated under the new path. The old files at `~/.config/agent/` become orphaned and can be safely deleted:
+
+```bash
+rm -rf ~/.config/agent/github-token ~/.config/agent/github-token.meta ~/.config/agent/github-app-env
+```
+
+### AGENT_NAME for git credential helper
+
+`bin/git-credential-github-app.sh` is invoked by **git itself** outside the Claude harness. Git inherits the user's shell environment, where `AGENT_NAME` may not be set. To ensure the credential helper finds the correct per-agent token, export `AGENT_NAME` in your shell profile:
+
+```bash
+# ~/.bashrc or ~/.zshrc
+export AGENT_NAME="jack"  # or "henry", etc.
+```
+
+Or in a systemd unit: `Environment=AGENT_NAME=jack`
+
+If `AGENT_NAME` is not set, the credential helper falls back to `~/.agents/_UNKNOWN/.config/`, which may collide with other unconfigured agents.
+
 ## Related
 
 - **[github](../github)** plugin — GitHub CLI installation, usage skill, and general auth

plugins/github-app/bin/token-check.sh

@@ -94,7 +94,7 @@ release_lock() {
 }
 
 # Get token minutes remaining (shared utility)
-PLUGIN_DIR="$(cd "$(dirname "$0")/.." && pwd)"
+PLUGIN_DIR="$(cd "$(dirname "$_self")/.." && pwd)"
 source "$PLUGIN_DIR/lib/token-utils.sh"
 
 # Update the runtime env file with current token

plugins/github-app/hooks/scripts/github-token-check.sh

@@ -22,7 +22,7 @@ set -euo pipefail
 # --- Configuration ---
 
 # shellcheck source=../../lib/agent-paths.sh
-source "$(cd "$(dirname "$0")/../.." && pwd)/lib/agent-paths.sh"
+source "${CLAUDE_PLUGIN_ROOT}/lib/agent-paths.sh"
 
 DEBOUNCE_FILE="${AGENT_CONFIG_DIR}/github-app-last-check"
 DEBOUNCE_SECONDS=30  # Don't check more often than every 30 seconds

plugins/github-app/lib/agent-paths.sh

@@ -8,4 +8,7 @@
 # Usage: source "$(dirname "$0")/../lib/agent-paths.sh"
 #   or:  source "${CLAUDE_PLUGIN_ROOT}/lib/agent-paths.sh"
 
+[[ -n "${_AGENT_PATHS_LOADED:-}" ]] && return 0
+_AGENT_PATHS_LOADED=1
+
 AGENT_CONFIG_DIR="${HOME}/.agents/${AGENT_NAME:-_UNKNOWN}/.config"