Skip to content

Commit f97c75f

Browse files
committed
fix: address PR review feedback on scoring rules and template sync
- Replace arbitrary 94% scoring cap with "should reflect that no category achieved ✅ level" (removes magic number) - Change >95% "just the table" instruction to "minimal (table + brief summary)" to avoid conflicting with CI prompt format requirements - Sync prompt-template.md verdict criteria with CI prompt: add style/convention, maintainability criteria for REQUEST_CHANGES; add previous feedback and break-after-merge criteria for APPROVE; add "bar for non-blocking feedback" paragraph https://claude.ai/code/session_01RB1y75VoeNNB7sucmusnmM
1 parent a5bb23c commit f97c75f

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

plugins/scm-utils/skills/code-review/references/prompt-template.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,26 @@ Questions you leave in past reviews may be answered in the PR body or comments.
128128
10. **Submit the review**: Use `mcp__github__submit_pending_pull_request_review` to post your review.
129129
130130
Use **"REQUEST_CHANGES"** when:
131-
- Security, performance, or correctness issues must be fixed before merging
131+
- Security, performance, or correctness issues exist that must be fixed before merging
132+
- Style or convention violations need correction before merging
133+
- Maintainability or complexity issues would degrade the codebase if merged
132134
- The code would improve meaningfully from a suggested change and the change is straightforward to make
133135
- CRITICAL: If a change would make the code better and it's reasonable to do before merge, it's a requested change, not a suggestion
134136
135137
Use **"APPROVE"** when:
136-
- The PR is ready to merge as-is with no outstanding issues
138+
- The PR is ready to merge as-is (barring CI issues which you do not evaluate)
139+
- No outstanding issues need to be addressed
140+
- Previous feedback has been adequately addressed (e.g., author clarified logic in PR body, commit messages, or code comments)
141+
- CRITICAL: If the code changes will break something after merge, do NOT approve
137142
138143
Use **"COMMENT"** only when ALL of these are true:
139144
- The code won't break if merged as-is
140-
- The suggestions are genuinely optional and there is a clear reason why each should NOT be addressed in this PR
141-
- CRITICAL: If a suggestion would improve the code and is reasonable to implement, use REQUEST_CHANGES. Non-blocking feedback must have a justification.
145+
- The suggestions are genuinely optional improvements that don't affect code quality for the current change
146+
- There is a clear, specific reason why each suggestion should NOT be addressed in this PR (e.g., out of scope, requires broader refactoring, needs design discussion first)
147+
- CRITICAL: If a suggestion would improve the code and is reasonable to implement before merge, use REQUEST_CHANGES instead. "Non-blocking" must have a justification — vague suggestions that could easily be applied are blocking.
148+
149+
**The bar for non-blocking feedback:**
150+
The goal is to merge high-quality code. If your feedback would improve the code, and the improvement is within the scope of the PR and straightforward to implement, then it IS blocking and should use REQUEST_CHANGES. Non-blocking feedback should be reserved for items that genuinely warrant discussion about whether they should be addressed at all, or that would require work significantly beyond the PR's scope.
142151

143152
11. **Post-review verification**: After submitting your review, re-read the PR and all comments to ensure correct state.
144153

shared/skills/self-review/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ When all agents complete, review each report. Compare results across dimensions
6161
- 🚨 Score below 70%
6262
- ⚠️ Score below 85%
6363
- ✅ Score 85% or above
64-
- If any category has ⚠️, the maximum overall score is 94%
65-
- If overall score is >95%, keep the final review to just the table
64+
- If any category has ⚠️, the overall score should reflect that no category achieved ✅ level
65+
- If overall score is >95%, the detailed section can be minimal (just the table and a brief summary)
6666
- References from sub-agents should be verbose and verifiable
6767

6868
### Step 4: Post Review

0 commit comments

Comments
 (0)