You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: address PR review feedback on scoring rules and template sync
- Replace arbitrary 94% scoring cap with "should reflect that no
category achieved ✅ level" (removes magic number)
- Change >95% "just the table" instruction to "minimal (table + brief
summary)" to avoid conflicting with CI prompt format requirements
- Sync prompt-template.md verdict criteria with CI prompt: add
style/convention, maintainability criteria for REQUEST_CHANGES;
add previous feedback and break-after-merge criteria for APPROVE;
add "bar for non-blocking feedback" paragraph
https://claude.ai/code/session_01RB1y75VoeNNB7sucmusnmM
Copy file name to clipboardExpand all lines: plugins/scm-utils/skills/code-review/references/prompt-template.md
+13-4Lines changed: 13 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -128,17 +128,26 @@ Questions you leave in past reviews may be answered in the PR body or comments.
128
128
10. **Submit the review**: Use `mcp__github__submit_pending_pull_request_review` to post your review.
129
129
130
130
Use **"REQUEST_CHANGES"** when:
131
-
- Security, performance, or correctness issues must be fixed before merging
131
+
- Security, performance, or correctness issues exist that must be fixed before merging
132
+
- Style or convention violations need correction before merging
133
+
- Maintainability or complexity issues would degrade the codebase if merged
132
134
- The code would improve meaningfully from a suggested change and the change is straightforward to make
133
135
- CRITICAL: If a change would make the code better and it's reasonable to do before merge, it's a requested change, not a suggestion
134
136
135
137
Use **"APPROVE"** when:
136
-
- The PR is ready to merge as-is with no outstanding issues
138
+
- The PR is ready to merge as-is (barring CI issues which you do not evaluate)
139
+
- No outstanding issues need to be addressed
140
+
- Previous feedback has been adequately addressed (e.g., author clarified logic in PR body, commit messages, or code comments)
141
+
- CRITICAL: If the code changes will break something after merge, do NOT approve
137
142
138
143
Use **"COMMENT"** only when ALL of these are true:
139
144
- The code won't breakif merged as-is
140
-
- The suggestions are genuinely optional and there is a clear reason why each should NOT be addressed in this PR
141
-
- CRITICAL: If a suggestion would improve the code and is reasonable to implement, use REQUEST_CHANGES. Non-blocking feedback must have a justification.
145
+
- The suggestions are genuinely optional improvements that don't affect code quality for the current change
146
+
- There is a clear, specific reason why each suggestion should NOT be addressed in this PR (e.g., out of scope, requires broader refactoring, needs design discussion first)
147
+
- CRITICAL: If a suggestion would improve the code and is reasonable to implement before merge, use REQUEST_CHANGES instead. "Non-blocking" must have a justification — vague suggestions that could easily be applied are blocking.
148
+
149
+
**The bar for non-blocking feedback:**
150
+
The goal is to merge high-quality code. If your feedback would improve the code, and the improvement is within the scope of the PR and straightforward to implement, then it IS blocking and should use REQUEST_CHANGES. Non-blocking feedback should be reserved for items that genuinely warrant discussion about whether they should be addressed at all, or that would require work significantly beyond the PR's scope.
142
151
143
152
11. **Post-review verification**: After submitting your review, re-read the PR and all comments to ensure correct state.
0 commit comments