add tests, fix small issues

Author: ntietje1

convex/notes/__tests__/createNoteYjsIntegration.test.ts

@@ -0,0 +1,59 @@
+import { describe, expect, it } from 'vitest'
+import * as Y from 'yjs'
+import { createTestContext } from '../../_test/setup.helper'
+import { asDm, setupCampaignContext } from '../../_test/identities.helper'
+import { api } from '../../_generated/api'
+
+describe('createNote YJS integration', () => {
+  const t = createTestContext()
+
+  it('creates a yjsUpdates row when creating a note', async () => {
+    const ctx = await setupCampaignContext(t)
+    const dmAuth = asDm(ctx)
+
+    const { noteId } = await dmAuth.mutation(api.notes.mutations.createNote, {
+      campaignId: ctx.campaignId,
+      name: 'Test Note',
+      parentId: null,
+    })
+
+    const updates = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+
+    expect(updates).toHaveLength(1)
+    expect(updates[0].seq).toBe(0)
+    expect(updates[0].isSnapshot).toBe(true)
+  })
+
+  it('creates valid YJS document for note without content', async () => {
+    const ctx = await setupCampaignContext(t)
+    const dmAuth = asDm(ctx)
+
+    const { noteId } = await dmAuth.mutation(api.notes.mutations.createNote, {
+      campaignId: ctx.campaignId,
+      name: 'Empty Note',
+      parentId: null,
+    })
+
+    const updates = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+
+    expect(updates).toHaveLength(1)
+
+    const doc = new Y.Doc()
+    Y.applyUpdate(doc, new Uint8Array(updates[0].update))
+
+    const fragment = doc.getXmlFragment('document')
+    expect(fragment).toBeDefined()
+
+    doc.destroy()
+  })
+})

convex/sidebarItems/__tests__/hardDeleteYjsCleanup.test.ts

@@ -0,0 +1,129 @@
+import { describe, expect, it } from 'vitest'
+import { createTestContext } from '../../_test/setup.helper'
+import { asDm, setupCampaignContext } from '../../_test/identities.helper'
+import { createFolder } from '../../_test/factories.helper'
+import { api } from '../../_generated/api'
+
+describe('hard delete YJS cleanup', () => {
+  const t = createTestContext()
+
+  it('hard-deleting a note removes its yjsUpdates', async () => {
+    const ctx = await setupCampaignContext(t)
+    const dmAuth = asDm(ctx)
+
+    const { noteId } = await dmAuth.mutation(api.notes.mutations.createNote, {
+      campaignId: ctx.campaignId,
+      name: 'Doomed Note',
+      parentId: null,
+    })
+
+    const updatesBefore = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(updatesBefore).toHaveLength(1)
+
+    await dmAuth.mutation(api.sidebarItems.mutations.moveSidebarItem, {
+      itemId: noteId,
+      location: 'trash',
+    })
+
+    await dmAuth.mutation(api.sidebarItems.mutations.emptyTrashBin, {
+      campaignId: ctx.campaignId,
+    })
+
+    const updatesAfter = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(updatesAfter).toHaveLength(0)
+  })
+
+  it('hard-deleting a note removes its yjsAwareness entries', async () => {
+    const ctx = await setupCampaignContext(t)
+    const dmAuth = asDm(ctx)
+
+    const { noteId } = await dmAuth.mutation(api.notes.mutations.createNote, {
+      campaignId: ctx.campaignId,
+      name: 'Awareness Note',
+      parentId: null,
+    })
+
+    await dmAuth.mutation(api.yjsSync.mutations.pushAwareness, {
+      documentId: noteId,
+      clientId: 42,
+      state: new ArrayBuffer(4),
+    })
+
+    const awarenessBefore = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsAwareness')
+        .withIndex('by_document', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(awarenessBefore).toHaveLength(1)
+
+    await dmAuth.mutation(api.sidebarItems.mutations.moveSidebarItem, {
+      itemId: noteId,
+      location: 'trash',
+    })
+
+    await dmAuth.mutation(api.sidebarItems.mutations.emptyTrashBin, {
+      campaignId: ctx.campaignId,
+    })
+
+    const awarenessAfter = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsAwareness')
+        .withIndex('by_document', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(awarenessAfter).toHaveLength(0)
+  })
+
+  it('hard-deleting a folder cascades YJS cleanup for contained notes', async () => {
+    const ctx = await setupCampaignContext(t)
+    const dmAuth = asDm(ctx)
+
+    const { folderId } = await createFolder(
+      t,
+      ctx.campaignId,
+      ctx.dm.profile._id,
+    )
+
+    const { noteId } = await dmAuth.mutation(api.notes.mutations.createNote, {
+      campaignId: ctx.campaignId,
+      name: 'Nested Note',
+      parentId: folderId,
+    })
+
+    const updatesBefore = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(updatesBefore).toHaveLength(1)
+
+    await dmAuth.mutation(api.sidebarItems.mutations.moveSidebarItem, {
+      itemId: folderId,
+      location: 'trash',
+    })
+
+    await dmAuth.mutation(api.sidebarItems.mutations.emptyTrashBin, {
+      campaignId: ctx.campaignId,
+    })
+
+    const updatesAfter = await t.run(async (dbCtx) => {
+      return await dbCtx.db
+        .query('yjsUpdates')
+        .withIndex('by_document_seq', (q) => q.eq('documentId', noteId))
+        .collect()
+    })
+    expect(updatesAfter).toHaveLength(0)
+  })
+})