Skip to content

Commit 582c7a6

Browse files
authored
Fix show tags refresh (#2799)
* fix show tags fresh Signed-off-by: sharpd <davidsharp7@gmail.com> * disable show tags on version load Signed-off-by: sharpd <davidsharp7@gmail.com> --------- Signed-off-by: sharpd <davidsharp7@gmail.com>
1 parent dcde104 commit 582c7a6

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

web/src/components/datasets/DatasetDetailPage.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
105105

106106
useEffect(() => {
107107
fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
108-
}, [lineageDataset.name])
109-
110-
useEffect(() => {
111-
if (showTags) {
112-
fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
113-
}
114-
}, [showTags])
108+
}, [lineageDataset.name, showTags])
115109

116110
// if the dataset is deleted then redirect to datasets end point
117111
useEffect(() => {
@@ -219,6 +213,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
219213
checked={showTags}
220214
onChange={() => setShowTags(!showTags)}
221215
inputProps={{ 'aria-label': 'toggle show tags' }}
216+
disabled={versionsLoading}
222217
/>
223218
}
224219
label={i18next.t('datasets.show_field_tags')}

0 commit comments

Comments
 (0)