Skip to content

nuxt-i18n types (refering #132)#133

Merged
paulgv merged 1 commit intonuxt-modules:masterfrom
kevinmarrec:typings
Oct 6, 2018
Merged

nuxt-i18n types (refering #132)#133
paulgv merged 1 commit intonuxt-modules:masterfrom
kevinmarrec:typings

Conversation

@kevinmarrec
Copy link
Copy Markdown

Fixes #132

@paulgv
Copy link
Copy Markdown
Collaborator

paulgv commented Oct 6, 2018

Thank you @kevinmarrec

@paulgv paulgv merged commit 817c58e into nuxt-modules:master Oct 6, 2018
@kevinmarrec
Copy link
Copy Markdown
Author

kevinmarrec commented Nov 12, 2018

@paulgv I'm working on nuxt/nuxt#4164 since few weeks, and on the way I figured out I've some improvements to do around nuxt-i18n regarding what I've already done through this PR.

  1. TypeScript Convention (it's just about dobule quotes and some semi-colons)
  2. Add tests (There will be tests regarding types around nuxt, so having typing tests around here should be nice too)

So I'll open a new issue and PR soon

EDIT : PR is here : #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants