Skip to content

Commit abbaf8d

Browse files
authored
*: bump tidb to update version parsing (pingcap#12575)
close pingcap#12574
1 parent 6c0bc22 commit abbaf8d

File tree

3 files changed

+32
-31
lines changed

3 files changed

+32
-31
lines changed

go.mod

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ require (
7070
github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
7171
github.com/pierrec/lz4/v4 v4.1.22
7272
github.com/pingcap/check v0.0.0-20211026125417-57bd13f7b5f0
73-
github.com/pingcap/errors v0.11.5-0.20250523034308-74f78ae071ee
73+
github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2
7474
github.com/pingcap/failpoint v0.0.0-20240528011301-b51a646c7c86
75-
github.com/pingcap/kvproto v0.0.0-20260120063856-d09230288811
75+
github.com/pingcap/kvproto v0.0.0-20260320060847-534bbfabf736
7676
github.com/pingcap/log v1.1.1-0.20250917021125-19901e015dc9
77-
github.com/pingcap/tidb v1.1.0-beta.0.20260306054132-ef17075bb9eb
77+
github.com/pingcap/tidb v1.1.0-beta.0.20260325043212-0c4df2e19ecc
7878
github.com/pingcap/tidb-dashboard v0.0.0-20240326110213-9768844ff5d7
79-
github.com/pingcap/tidb/pkg/parser v0.0.0-20260306054132-ef17075bb9eb
79+
github.com/pingcap/tidb/pkg/parser v0.0.0-20260325043212-0c4df2e19ecc
8080
github.com/prometheus/client_golang v1.23.0
8181
github.com/prometheus/client_model v0.6.2
8282
github.com/r3labs/diff v1.1.0
@@ -91,9 +91,9 @@ require (
9191
github.com/stretchr/testify v1.11.1
9292
github.com/syndtr/goleveldb v1.0.1-0.20210305035536-64b5b1c73954
9393
github.com/thanhpk/randstr v1.0.6
94-
github.com/tikv/client-go/v2 v2.0.8-0.20260225065730-dfa54d86781e
94+
github.com/tikv/client-go/v2 v2.0.8-0.20260319090224-0569333efa49
9595
github.com/tikv/pd v1.1.0-beta.0.20240407022249-7179657d129b
96-
github.com/tikv/pd/client v0.0.0-20260228084044-4f5039d43753
96+
github.com/tikv/pd/client v0.0.0-20260323032024-d7b638033a14
9797
github.com/tinylib/msgp v1.1.6
9898
github.com/uber-go/atomic v1.4.0
9999
github.com/vmihailenco/msgpack/v5 v5.3.5
@@ -373,7 +373,7 @@ require (
373373
github.com/pingcap/fn v1.0.0 // indirect
374374
github.com/pingcap/goleveldb v0.0.0-20191226122134-f82aafb29989 // indirect
375375
github.com/pingcap/sysutil v1.0.1-0.20240311050922-ae81ee01f3a5
376-
github.com/pingcap/tipb v0.0.0-20251230094608-1374320b4bd8 // indirect
376+
github.com/pingcap/tipb v0.0.0-20260210113932-1447c9d7e9fe // indirect
377377
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
378378
github.com/pkg/errors v0.9.1 // indirect
379379
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect

go.sum

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -870,17 +870,17 @@ github.com/pingcap/check v0.0.0-20211026125417-57bd13f7b5f0/go.mod h1:PYMCGwN0JH
870870
github.com/pingcap/errors v0.11.0/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=
871871
github.com/pingcap/errors v0.11.4/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=
872872
github.com/pingcap/errors v0.11.5-0.20190809092503-95897b64e011/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=
873-
github.com/pingcap/errors v0.11.5-0.20250523034308-74f78ae071ee h1:/IDPbpzkzA97t1/Z1+C3KlxbevjMeaI6BQYxvivu4u8=
874-
github.com/pingcap/errors v0.11.5-0.20250523034308-74f78ae071ee/go.mod h1:X2r9ueLEUZgtx2cIogM0v4Zj5uvvzhuuiu7Pn8HzMPg=
873+
github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2 h1:cLgCk5mwDG9lDH+dPK8TmEliTjyGJwwKN0qevWAl8IY=
874+
github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2/go.mod h1:ktAJCA9lxrHHjVyVl2pKJFvzBnq2eZbb+CUOjBRPlXo=
875875
github.com/pingcap/failpoint v0.0.0-20240528011301-b51a646c7c86 h1:tdMsjOqUR7YXHoBitzdebTvOjs/swniBTOLy5XiMtuE=
876876
github.com/pingcap/failpoint v0.0.0-20240528011301-b51a646c7c86/go.mod h1:exzhVYca3WRtd6gclGNErRWb1qEgff3LYta0LvRmON4=
877877
github.com/pingcap/fn v1.0.0 h1:CyA6AxcOZkQh52wIqYlAmaVmF6EvrcqFywP463pjA8g=
878878
github.com/pingcap/fn v1.0.0/go.mod h1:u9WZ1ZiOD1RpNhcI42RucFh/lBuzTu6rw88a+oF2Z24=
879879
github.com/pingcap/goleveldb v0.0.0-20191226122134-f82aafb29989 h1:surzm05a8C9dN8dIUmo4Be2+pMRb6f55i+UIYrluu2E=
880880
github.com/pingcap/goleveldb v0.0.0-20191226122134-f82aafb29989/go.mod h1:O17XtbryoCJhkKGbT62+L2OlrniwqiGLSqrmdHCMzZw=
881881
github.com/pingcap/kvproto v0.0.0-20191211054548-3c6b38ea5107/go.mod h1:WWLmULLO7l8IOcQG+t+ItJ3fEcrL5FxF0Wu+HrMy26w=
882-
github.com/pingcap/kvproto v0.0.0-20260120063856-d09230288811 h1:kRQmRan/ddUlz3uCED/zQHGTAQaTvZ0Jtpk8MKFzm8E=
883-
github.com/pingcap/kvproto v0.0.0-20260120063856-d09230288811/go.mod h1:rXxWk2UnwfUhLXha1jxRWPADw9eMZGWEWCg92Tgmb/8=
882+
github.com/pingcap/kvproto v0.0.0-20260320060847-534bbfabf736 h1:GKdGsEfcE4ImbSN24AIt51t+3sUyqNTLoeUaJiZld8s=
883+
github.com/pingcap/kvproto v0.0.0-20260320060847-534bbfabf736/go.mod h1:rXxWk2UnwfUhLXha1jxRWPADw9eMZGWEWCg92Tgmb/8=
884884
github.com/pingcap/log v0.0.0-20191012051959-b742a5d432e9/go.mod h1:4rbK1p9ILyIfb6hU7OG2CiWSqMXnp3JMbiaVJ6mvoY8=
885885
github.com/pingcap/log v0.0.0-20210625125904-98ed8e2eb1c7/go.mod h1:8AanEdAHATuRurdGxZXBz0At+9avep+ub7U1AGYLIMM=
886886
github.com/pingcap/log v1.1.0/go.mod h1:DWQW5jICDR7UJh4HtxXSM20Churx4CQL0fwL/SoOSA4=
@@ -892,14 +892,14 @@ github.com/pingcap/sarama v1.41.2-pingcap-20250415 h1:jc/31lgAuSWLh8zr3y5bL0atpB
892892
github.com/pingcap/sarama v1.41.2-pingcap-20250415/go.mod h1:Kwi9CT6CuDYad3KS7HqjsbmD2DWkIKI7qI6a8PKlGb4=
893893
github.com/pingcap/sysutil v1.0.1-0.20240311050922-ae81ee01f3a5 h1:T4pXRhBflzDeAhmOQHNPRRogMYxP13V7BkYw3ZsoSfE=
894894
github.com/pingcap/sysutil v1.0.1-0.20240311050922-ae81ee01f3a5/go.mod h1:rlimy0GcTvjiJqvD5mXTRr8O2eNZPBrcUgiWVYp9530=
895-
github.com/pingcap/tidb v1.1.0-beta.0.20260306054132-ef17075bb9eb h1:DOueDIDo3gqBVlwJKrJ//gqAwP+3hGpXxLGFRlRdJeI=
896-
github.com/pingcap/tidb v1.1.0-beta.0.20260306054132-ef17075bb9eb/go.mod h1:yUgutduEAwjWgdlzqPfJXaEwO/q5OPFgQLg6VhX7FIc=
895+
github.com/pingcap/tidb v1.1.0-beta.0.20260325043212-0c4df2e19ecc h1:2Ateg1PUQqozi+TtbL+Bx62qn4IpQ48VTOpqCh2d3AI=
896+
github.com/pingcap/tidb v1.1.0-beta.0.20260325043212-0c4df2e19ecc/go.mod h1:lMVbvTSs9vvwxS65jJc01OjuX+lDCsJRjTKoNX0QWaQ=
897897
github.com/pingcap/tidb-dashboard v0.0.0-20240326110213-9768844ff5d7 h1:eFu98FbfJB7PKWOtkaV6YNXXJWqDhczQX56j/iucgU4=
898898
github.com/pingcap/tidb-dashboard v0.0.0-20240326110213-9768844ff5d7/go.mod h1:ucZBRz52icb23T/5Z4CsuUHmarYiin7p2MeiVBe+o8c=
899-
github.com/pingcap/tidb/pkg/parser v0.0.0-20260306054132-ef17075bb9eb h1:jI0KsWZFQgy3nnFHHJfolRTS0bVPqt3L9CYZhQYO3wM=
900-
github.com/pingcap/tidb/pkg/parser v0.0.0-20260306054132-ef17075bb9eb/go.mod h1:oHE+ub2QaDERd+UNHe4z2BhFV2jZrm7VNOe6atR9AF4=
901-
github.com/pingcap/tipb v0.0.0-20251230094608-1374320b4bd8 h1:KT/h7b+7lP/P+5OuczNNV+/wsHj9d0L7Eu4ktB5VRIg=
902-
github.com/pingcap/tipb v0.0.0-20251230094608-1374320b4bd8/go.mod h1:RM8iRcMalzOthG2XJxnNBniM4xFGb/lDwHUwqkaVzt4=
899+
github.com/pingcap/tidb/pkg/parser v0.0.0-20260325043212-0c4df2e19ecc h1:7triig1IRjVq3iZSwpG6OEs3b6IUSjS3NmPYxohApYE=
900+
github.com/pingcap/tidb/pkg/parser v0.0.0-20260325043212-0c4df2e19ecc/go.mod h1:zDLDsfNBU5+L6T4J9/OgWAHc/WZvMUjbpgHqQ/t3yKo=
901+
github.com/pingcap/tipb v0.0.0-20260210113932-1447c9d7e9fe h1:Zmz9mON+2NoKDVjkJbk6NZbFoTzVzk8MPTbRnu+MiVM=
902+
github.com/pingcap/tipb v0.0.0-20260210113932-1447c9d7e9fe/go.mod h1:RM8iRcMalzOthG2XJxnNBniM4xFGb/lDwHUwqkaVzt4=
903903
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c h1:+mdjkGKdHQG3305AYmdv1U2eRNDiU2ErMBj1gwrq8eQ=
904904
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c/go.mod h1:7rwL4CYBLnjLxUqIJNnCWiEdr3bn6IUYi15bNlnbCCU=
905905
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
@@ -1047,6 +1047,7 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
10471047
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
10481048
github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
10491049
github.com/stretchr/testify v1.8.3/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
1050+
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
10501051
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
10511052
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
10521053
github.com/syndtr/goleveldb v1.0.1-0.20210305035536-64b5b1c73954 h1:xQdMZ1WLrgkkvOZ/LDQxjVxMLdby7osSh4ZEVa5sIjs=
@@ -1081,12 +1082,12 @@ github.com/tidwall/rtred v0.1.2 h1:exmoQtOLvDoO8ud++6LwVsAMTu0KPzLTUrMln8u1yu8=
10811082
github.com/tidwall/rtred v0.1.2/go.mod h1:hd69WNXQ5RP9vHd7dqekAz+RIdtfBogmglkZSRxCHFQ=
10821083
github.com/tidwall/tinyqueue v0.1.1 h1:SpNEvEggbpyN5DIReaJ2/1ndroY8iyEGxPYxoSaymYE=
10831084
github.com/tidwall/tinyqueue v0.1.1/go.mod h1:O/QNHwrnjqr6IHItYrzoHAKYhBkLI67Q096fQP5zMYw=
1084-
github.com/tikv/client-go/v2 v2.0.8-0.20260225065730-dfa54d86781e h1:Ts6PeD2egs47PF7QqgbHZ3Wl7arO2peyz95T7mSQii8=
1085-
github.com/tikv/client-go/v2 v2.0.8-0.20260225065730-dfa54d86781e/go.mod h1:4jHqtFu0MeXVYFbka4yTZRxV/nR1Jw46hkyD5qhxi7s=
1085+
github.com/tikv/client-go/v2 v2.0.8-0.20260319090224-0569333efa49 h1:PzPBJW3y7WAX1fJ92U6qvjWGvoqpMpESsBbOsAPRzPM=
1086+
github.com/tikv/client-go/v2 v2.0.8-0.20260319090224-0569333efa49/go.mod h1:2itxkVYz1s+dKsfJZqKcFD2MGUoDxvyy/Yqjd7vkdjg=
10861087
github.com/tikv/pd v1.1.0-beta.0.20240407022249-7179657d129b h1:t2XoZp4UHrkPpYPsxbRTRVExJnriWlh+ZsDIfpYyd98=
10871088
github.com/tikv/pd v1.1.0-beta.0.20240407022249-7179657d129b/go.mod h1:7HJMdb0O5umNpZIFt8e/wKAcEmH99n2HsYgXX+vZj3k=
1088-
github.com/tikv/pd/client v0.0.0-20260228084044-4f5039d43753 h1:WSiznlCpoBCnJMZt5nHDC0Ig8PvQ9O+rgVSO7gwU44o=
1089-
github.com/tikv/pd/client v0.0.0-20260228084044-4f5039d43753/go.mod h1:tloQKNFqF/T5JfLx4bloR8MKPZyp7y6cF3guAlls88M=
1089+
github.com/tikv/pd/client v0.0.0-20260323032024-d7b638033a14 h1:TVSx20m6DZMSiI37Dduu9RZb8yUvT1sgW8kCLAe+T5U=
1090+
github.com/tikv/pd/client v0.0.0-20260323032024-d7b638033a14/go.mod h1:4kxXuAQAREpH+lVbydVwGNNDmcwdj0RG4Ofwky08W/k=
10901091
github.com/tinylib/msgp v1.1.6 h1:i+SbKraHhnrf9M5MYmvQhFnbLhAXSDWF8WWsuyRdocw=
10911092
github.com/tinylib/msgp v1.1.6/go.mod h1:75BAfg2hauQhs3qedfdDZmWAPcFMAvJE5b9rGOMufyw=
10921093
github.com/tjfoc/gmsm v1.3.2/go.mod h1:HaUcFuY0auTiaHB9MHFGCPx5IaLhTUd2atbCFBQXn9w=
@@ -1224,7 +1225,6 @@ go.opentelemetry.io/proto/otlp v1.7.0 h1:jX1VolD6nHuFzOYso2E73H85i92Mv8JQYk0K9vz
12241225
go.opentelemetry.io/proto/otlp v1.7.0/go.mod h1:fSKjH6YJ7HDlwzltzyMj036AJ3ejJLCgCSHGj4efDDo=
12251226
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
12261227
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
1227-
go.uber.org/atomic v1.6.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
12281228
go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
12291229
go.uber.org/atomic v1.9.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
12301230
go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE=

sync_diff_inspector/utils/pd.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"context"
1818
"database/sql"
1919
"fmt"
20-
"regexp"
2120
"sort"
2221
"strconv"
2322
"strings"
@@ -26,6 +25,7 @@ import (
2625
"github.com/coreos/go-semver/semver"
2726
"github.com/pingcap/errors"
2827
"github.com/pingcap/log"
28+
brversion "github.com/pingcap/tidb/br/pkg/version"
2929
"github.com/pingcap/tidb/pkg/util/dbutil"
3030
pd "github.com/tikv/pd/client"
3131
clientv3 "go.etcd.io/etcd/client/v3"
@@ -39,10 +39,7 @@ const (
3939
defaultGCSafePointTTL = 5 * 60
4040
)
4141

42-
var (
43-
tidbVersionRegex = regexp.MustCompile(`-[v]?\d+\.\d+\.\d+([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?`)
44-
autoGCSafePointVersion = semver.New("4.0.0")
45-
)
42+
var autoGCSafePointVersion = semver.New("4.0.0")
4643

4744
func getPDDDLIDs(pCtx context.Context, cli *clientv3.Client) ([]string, error) {
4845
ctx, cancel := context.WithTimeout(pCtx, 10*time.Second)
@@ -170,11 +167,15 @@ func GetSpecifiedColumnValueAndClose(rows *sql.Rows, columnName string) ([]strin
170167
return strs, errors.Trace(rows.Err())
171168
}
172169

173-
// parse versino string to semver.Version
170+
// parseVersion parses a version string to semver.Version.
171+
// It supports both classic TiDB versions (e.g. "8.0.11-TiDB-v9.0.0") and
172+
// TiDB-X versions (e.g. "8.0.11-TiDB-CLOUD.202603.0").
174173
func parseVersion(versionStr string) (*semver.Version, error) {
175-
versionStr = tidbVersionRegex.FindString(versionStr)[1:]
176-
versionStr = strings.TrimPrefix(versionStr, "v")
177-
return semver.NewVersion(versionStr)
174+
info := brversion.ParseServerInfo(versionStr)
175+
if info.ServerType != brversion.ServerTypeTiDB {
176+
return nil, fmt.Errorf("unrecognized TiDB version: %s", versionStr)
177+
}
178+
return info.ServerVersion, nil
178179
}
179180

180181
// TryToGetVersion gets the version of current db.

0 commit comments

Comments
 (0)