all: Enforce weak / global functions

Author: german77

include/devenv/seadFontMgr.h

@@ -34,7 +34,7 @@ class UniformBlockBuffer
 class FontBase
 {
 public:
-    virtual ~FontBase();
+    virtual ~FontBase() = default;
 
     virtual float getHeight() const = 0;
     virtual float getWidth() const = 0;

include/gfx/seadFrameBuffer.h

@@ -31,7 +31,7 @@ class LogicalFrameBuffer
           mPhysicalArea(physical_x, physical_y, physical_x + physical_w, physical_y + physical_h)
     {
     }
-    virtual ~LogicalFrameBuffer();
+    virtual ~LogicalFrameBuffer() = default;
 
     const Vector2f& getVirtualSize() const { return mVirtualSize; }
     const BoundBox2f& getPhysicalArea() const { return mPhysicalArea; }

include/gfx/seadProjection.h

@@ -21,7 +21,7 @@ class Projection
 
 public:
     Projection();
-    virtual ~Projection() = default;
+    virtual ~Projection();
 
     virtual f32 getNear() const = 0;
     virtual f32 getFar() const = 0;
@@ -72,7 +72,7 @@ class PerspectiveProjection : public Projection
 public:
     PerspectiveProjection();
     PerspectiveProjection(f32 near, f32 far, f32 fovy_rad, f32 aspect);
-    ~PerspectiveProjection() override;
+    ~PerspectiveProjection() override = default;
 
     f32 getNear() const override;
     f32 getFar() const override;

include/resource/seadResource.h

@@ -58,6 +58,7 @@ class IndirectResource : public Resource
 
 public:
     IndirectResource();
+    ~IndirectResource() override;
 
     void create(sead::ReadStream* stream, u32 size, sead::Heap* heap);
 

modules/src/devenv/seadFontMgr.cpp

@@ -2,5 +2,4 @@
 
 namespace sead
 {
-FontBase::~FontBase() = default;
 }  // namespace sead

modules/src/gfx/seadFrameBuffer.cpp

@@ -2,8 +2,6 @@
 
 namespace sead
 {
-LogicalFrameBuffer::~LogicalFrameBuffer() = default;
-
 FrameBuffer::~FrameBuffer() = default;
 
 void FrameBuffer::clearMRT(DrawContext*, u32, const Color4f&) const {}

modules/src/gfx/seadProjection.cpp

@@ -12,6 +12,8 @@ Projection::Projection()
     mDeviceZOffset = Graphics::sDefaultDeviceZOffset;
 }
 
+Projection::~Projection() = default;
+
 void Projection::updateAttributesForDirectProjection() {}
 
 const Matrix44f& Projection::getProjectionMatrix() const

modules/src/math/seadMathCalcCommon.cpp

@@ -609,8 +609,58 @@ const MathCalcCommon<f32>::LogSample MathCalcCommon<f32>::cLogTbl[256 + 1]{
     {0.6931471824645996, 0.0019512200960889459},
 };
 
-template <typename T>
-T MathCalcCommon<T>::gcd(T x, T y)
+template <>
+s32 MathCalcCommon<s32>::gcd(s32 x, s32 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+
+    while (x != y)
+    {
+        if (x > y)
+            x -= y;
+        else
+            y -= x;
+    }
+
+    return x;
+}
+
+template <>
+s32 MathCalcCommon<s32>::lcm(s32 x, s32 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+    return x / gcd(x, y) * y;
+}
+
+template <>
+u32 MathCalcCommon<u32>::gcd(u32 x, u32 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+
+    while (x != y)
+    {
+        if (x > y)
+            x -= y;
+        else
+            y -= x;
+    }
+
+    return x;
+}
+
+template <>
+u32 MathCalcCommon<u32>::lcm(u32 x, u32 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+    return x / gcd(x, y) * y;
+}
+
+template <>
+s64 MathCalcCommon<s64>::gcd(s64 x, s64 y)
 {
     if (x == 0 || y == 0)
         return 0;
@@ -626,18 +676,38 @@ T MathCalcCommon<T>::gcd(T x, T y)
     return x;
 }
 
-template <typename T>
-T MathCalcCommon<T>::lcm(T x, T y)
+template <>
+s64 MathCalcCommon<s64>::lcm(s64 x, s64 y)
 {
     if (x == 0 || y == 0)
         return 0;
     return x / gcd(x, y) * y;
 }
 
-template s32 MathCalcCommon<s32>::gcd(s32 x, s32 y);
-template s32 MathCalcCommon<s32>::lcm(s32 x, s32 y);
-template u32 MathCalcCommon<u32>::gcd(u32 x, u32 y);
-template u32 MathCalcCommon<u32>::lcm(u32 x, u32 y);
+template <>
+u64 MathCalcCommon<u64>::gcd(u64 x, u64 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+
+    while (x != y)
+    {
+        if (x > y)
+            x -= y;
+        else
+            y -= x;
+    }
+
+    return x;
+}
+
+template <>
+u64 MathCalcCommon<u64>::lcm(u64 x, u64 y)
+{
+    if (x == 0 || y == 0)
+        return 0;
+    return x / gcd(x, y) * y;
+}
 
 template <>
 u32 MathCalcCommon<f32>::atanIdx_(f32 t)