improve coverage

Author: dmitryax

pdata/xpdata/request/logs_request_test.go

@@ -17,16 +17,24 @@ import (
 
 func TestMarshalUnmarshalLogsRequest(t *testing.T) {
 	logs := testdata.GenerateLogs(3)
+
+	// unmarshal logs request with a context
 	spanCtx := fakeSpanContext(t)
 	buf, err := MarshalLogs(trace.ContextWithSpanContext(context.Background(), spanCtx), logs)
 	require.NoError(t, err)
-
-	// happy path: unmarshal logs request
 	gotCtx, gotLogs, err := UnmarshalLogs(buf)
 	require.NoError(t, err)
 	assert.Equal(t, spanCtx, trace.SpanContextFromContext(gotCtx))
 	assert.Equal(t, logs, gotLogs)
 
+	// unmarshal logs request with empty context
+	buf, err = MarshalLogs(context.Background(), logs)
+	require.NoError(t, err)
+	gotCtx, gotLogs, err = UnmarshalLogs(buf)
+	require.NoError(t, err)
+	assert.Equal(t, context.Background(), gotCtx)
+	assert.Equal(t, logs, gotLogs)
+
 	// unmarshal corrupted data
 	_, _, err = UnmarshalLogs(buf[:len(buf)-1])
 	require.ErrorContains(t, err, "failed to unmarshal logs request")

pdata/xpdata/request/metrics_request_test.go

@@ -17,16 +17,24 @@ import (
 
 func TestMarshalUnmarshalMetricsRequest(t *testing.T) {
 	metrics := testdata.GenerateMetrics(3)
+
+	// unmarshal metrics request with a context
 	spanCtx := fakeSpanContext(t)
 	buf, err := MarshalMetrics(trace.ContextWithSpanContext(context.Background(), spanCtx), metrics)
 	require.NoError(t, err)
-
-	// happy path: unmarshal metrics request
 	gotCtx, gotMetrics, err := UnmarshalMetrics(buf)
 	require.NoError(t, err)
 	assert.Equal(t, spanCtx, trace.SpanContextFromContext(gotCtx))
 	assert.Equal(t, metrics, gotMetrics)
 
+	// unmarshal metrics request with empty context
+	buf, err = MarshalMetrics(context.Background(), metrics)
+	require.NoError(t, err)
+	gotCtx, gotMetrics, err = UnmarshalMetrics(buf)
+	require.NoError(t, err)
+	assert.Equal(t, context.Background(), gotCtx)
+	assert.Equal(t, metrics, gotMetrics)
+
 	// unmarshal corrupted data
 	_, _, err = UnmarshalMetrics(buf[:len(buf)-1])
 	require.ErrorContains(t, err, "failed to unmarshal metrics request")

pdata/xpdata/request/profiles_request_test.go

@@ -17,16 +17,24 @@ import (
 
 func TestMarshalUnmarshalProfilesRequest(t *testing.T) {
 	profiles := testdata.GenerateProfiles(3)
+
+	// unmarshal profiles request with a context
 	spanCtx := fakeSpanContext(t)
 	buf, err := MarshalProfiles(trace.ContextWithSpanContext(context.Background(), spanCtx), profiles)
 	require.NoError(t, err)
-
-	// happy path: unmarshal profiles request
 	gotCtx, gotProfiles, err := UnmarshalProfiles(buf)
 	require.NoError(t, err)
 	assert.Equal(t, spanCtx, trace.SpanContextFromContext(gotCtx))
 	assert.Equal(t, profiles, gotProfiles)
 
+	// unmarshal profiles request with empty context
+	buf, err = MarshalProfiles(context.Background(), profiles)
+	require.NoError(t, err)
+	gotCtx, gotProfiles, err = UnmarshalProfiles(buf)
+	require.NoError(t, err)
+	assert.Equal(t, context.Background(), gotCtx)
+	assert.Equal(t, profiles, gotProfiles)
+
 	// unmarshal corrupted data
 	_, _, err = UnmarshalProfiles(buf[:len(buf)-1])
 	require.ErrorContains(t, err, "failed to unmarshal profiles request")

pdata/xpdata/request/traces_request_test.go

@@ -17,16 +17,24 @@ import (
 
 func TestMarshalUnmarshalTracesRequest(t *testing.T) {
 	traces := testdata.GenerateTraces(3)
+
+	// unmarshal traces request with a context
 	spanCtx := fakeSpanContext(t)
 	buf, err := MarshalTraces(trace.ContextWithSpanContext(context.Background(), spanCtx), traces)
 	require.NoError(t, err)
-
-	// happy path: unmarshal traces request
 	gotCtx, gotTraces, err := UnmarshalTraces(buf)
 	require.NoError(t, err)
 	assert.Equal(t, spanCtx, trace.SpanContextFromContext(gotCtx))
 	assert.Equal(t, traces, gotTraces)
 
+	// unmarshal traces request with empty context
+	buf, err = MarshalTraces(context.Background(), traces)
+	require.NoError(t, err)
+	gotCtx, gotTraces, err = UnmarshalTraces(buf)
+	require.NoError(t, err)
+	assert.Equal(t, context.Background(), gotCtx)
+	assert.Equal(t, traces, gotTraces)
+
 	// unmarshal corrupted data
 	_, _, err = UnmarshalTraces(buf[:len(buf)-1])
 	require.ErrorContains(t, err, "failed to unmarshal traces request")