Review fixes for nats-2.17:library (#18220)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>

Author: otelbot[bot]

instrumentation/nats/nats-2.17/library/src/main/java/io/opentelemetry/instrumentation/nats/v2_17/OpenTelemetryConnection.java

@@ -29,7 +29,7 @@ final class OpenTelemetryConnection implements InvocationHandler {
   private final Instrumenter<NatsRequest, NatsRequest> producerInstrumenter;
   private final Instrumenter<NatsRequest, Void> consumerProcessInstrumenter;
 
-  public OpenTelemetryConnection(
+  private OpenTelemetryConnection(
       Connection connection,
       Instrumenter<NatsRequest, NatsRequest> producerInstrumenter,
       Instrumenter<NatsRequest, Void> consumerProcessInstrumenter) {
@@ -38,7 +38,7 @@ public OpenTelemetryConnection(
     this.consumerProcessInstrumenter = consumerProcessInstrumenter;
   }
 
-  public static Connection wrap(
+  static Connection wrap(
       Connection connection,
       Instrumenter<NatsRequest, NatsRequest> producerInstrumenter,
       Instrumenter<NatsRequest, Void> consumerProcessInstrumenter) {

instrumentation/nats/nats-2.17/library/src/main/java/io/opentelemetry/instrumentation/nats/v2_17/OpenTelemetryDispatcher.java

@@ -21,13 +21,13 @@ final class OpenTelemetryDispatcher implements InvocationHandler {
   private final Dispatcher delegate;
   private final Instrumenter<NatsRequest, Void> consumerProcessInstrumenter;
 
-  public OpenTelemetryDispatcher(
+  private OpenTelemetryDispatcher(
       Dispatcher delegate, Instrumenter<NatsRequest, Void> consumerProcessInstrumenter) {
     this.delegate = delegate;
     this.consumerProcessInstrumenter = consumerProcessInstrumenter;
   }
 
-  public static Dispatcher wrap(
+  static Dispatcher wrap(
       Dispatcher delegate, Instrumenter<NatsRequest, Void> consumerProcessInstrumenter) {
     return (Dispatcher)
         Proxy.newProxyInstance(

instrumentation/nats/nats-2.17/metadata.yaml

@@ -5,6 +5,7 @@ semantic_conventions:
 library_link: https://nats.io/
 configurations:
   - name: otel.instrumentation.messaging.experimental.capture-headers
+    declarative_name: java.common.messaging.capture_headers/development
     description: >
       Enables capturing messaging headers as span attributes. Provide a comma-separated list of
       header names to capture.