Skip to content

Commit 6718d33

Browse files
authored
Review fixes for netty-4.1:library (#18226)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 93ef22f commit 6718d33

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

  • instrumentation/netty/netty-4.1/library/src/main/java/io/opentelemetry/instrumentation/netty/v4_1/internal

instrumentation/netty/netty-4.1/library/src/main/java/io/opentelemetry/instrumentation/netty/v4_1/internal/ProtocolSpecificEvent.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public enum ProtocolSpecificEvent {
3333
SWITCHING_PROTOCOLS("http.response.status_code.101.upgrade") {
3434

3535
@Override
36-
void addEvent(Context context, HttpRequest request, HttpResponse response) {
36+
void addEvent(Context context, @Nullable HttpRequest request, HttpResponse response) {
3737
Span.fromContext(context)
3838
.addEvent(
3939
eventName(),
@@ -62,6 +62,5 @@ public String eventName() {
6262
return eventName;
6363
}
6464

65-
abstract void addEvent(
66-
Context context, @Nullable HttpRequest request, @Nullable HttpResponse response);
65+
abstract void addEvent(Context context, @Nullable HttpRequest request, HttpResponse response);
6766
}

0 commit comments

Comments
 (0)