chore: Fixed phpstan errors (#1911)

* Fixed phpstan errors

* Fixed no_unused_import complaint

* Reverted

* Reverted

* tried adding reportUnmatchedIgnoredErrors parameter

* Tried to fix phpspec/prophecy to 1.22.* until PHP 8.1 is dropped

* Reverted

* Added phpstan error message suppression

* Tried fixing array access psalm complaint

* Reverted and add suppression

* Added psalm suppression

Author: jerrytfleung

composer.json

@@ -98,8 +98,8 @@
         "nyholm/psr7": "^1.4",
         "open-telemetry/dev-tools": "dev-main",
         "php-http/mock-client": "^1.5",
-        "phpdocumentor/reflection-docblock": "^6.0",
-        "phpspec/prophecy": "^1.22",
+        "phpdocumentor/reflection-docblock": "^5.2",
+        "phpspec/prophecy": "1.22.*",
         "phpspec/prophecy-phpunit": "^2",
         "phpstan/phpstan": "^1.10.13",
         "phpstan/phpstan-mockery": "^1.1",

phpstan.neon.dist

@@ -12,6 +12,7 @@ parameters:
     excludePaths:
         - tests/TraceContext/W3CTestService
         - tests/Unit/Config/SDK/Configuration/ExampleSdk
+    reportUnmatchedIgnoredErrors: false
     ignoreErrors:
         -
             message: "#Call to an undefined method .*#"
@@ -34,6 +35,12 @@ parameters:
             message: "#Call to an undefined method .*:expects.*#"
             paths:
                 - tests
+        -
+            message: "#Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface::.*#"
+            paths:
+                - src/Config/SDK
+                - tests/Unit/Config
+                - tests/Integration/Config
         -
             message: "#Cannot call method .* on null#"
             paths:
@@ -62,3 +69,7 @@ parameters:
             message: "#^Caught class .* not found\\.#"
             paths:
                 - src/Config/SDK/Configuration/Environment/Adapter/
+        -
+            message: "#^PHPDoc tag @extends contains generic type .* but class .* is not generic\\.#"
+            paths:
+                - src/Config/SDK/Configuration/Internal/NodeDefinition/

src/Config/SDK/Configuration/Internal/NodeDefinition/ArrayNodeDefinition.php

@@ -10,6 +10,7 @@
 use Symfony\Component\Config\Definition\NodeInterface;
 
 /**
+ * @internal
  * @extends \Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition<NodeParentInterface|null>
  */
 class ArrayNodeDefinition extends \Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition

src/SDK/Common/Exception/StackTraceFormatter.php

@@ -70,6 +70,7 @@ public static function format(Throwable $e): string
      * @psalm-param Frames $frames
      * @phan-suppress-next-line PhanTypeMismatchDeclaredParam
      * @psalm-param Frames|null $enclosing
+     * @psalm-suppress InvalidArrayOffset
      */
     private static function writeFrames(string &$s, array $frames, ?array $enclosing): void
     {

src/SDK/Common/Export/Http/PsrUtils.php

@@ -63,6 +63,7 @@ private static function parseRetryAfter(?ResponseInterface $response): int
     /**
      * @param list<string> $encodings
      * @param array<int, string>|null $appliedEncodings
+     * @psalm-suppress PossiblyInvalidArrayOffset
      */
     public static function encode(string $value, array $encodings, ?array &$appliedEncodings = null): string
     {

src/SDK/Metrics/Aggregation/ExplicitBucketHistogramAggregation.php

@@ -40,6 +40,7 @@ public function initialize(): ExplicitBucketHistogramSummary
 
     /**
      * @param ExplicitBucketHistogramSummary $summary
+     * @psalm-suppress InvalidArrayOffset
      */
     #[\Override]
     public function record($summary, $value, AttributesInterface $attributes, ContextInterface $context, int $timestamp): void

src/SDK/Metrics/Exemplar/HistogramBucketReservoir.php

@@ -25,6 +25,9 @@ public function __construct(array $boundaries)
         $this->boundaries = $boundaries;
     }
 
+    /**
+     * @psalm-suppress InvalidArrayOffset
+     */
     #[\Override]
     public function offer($index, $value, AttributesInterface $attributes, ContextInterface $context, int $timestamp): void
     {

tests/Integration/SDK/SpanBuilderTest.php

@@ -96,6 +96,9 @@ public function test_add_link_invalid(): void
         $span->end();
     }
 
+    /**
+     * @psalm-suppress InvalidArrayOffset
+     */
     public function test_add_link_dropping_links(): void
     {
         Logging::disable();