Skip to content

Commit 5b55fb7

Browse files
committed
Consistently use int64 type for string refs in pprofextended.
Fixing two fields that used a different type, I don't think there is a good reason to be inconsistent.
1 parent a05597b commit 5b55fb7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

opentelemetry/proto/profiles/v1experimental/pprofextended.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ message Sample {
235235
// Supersedes location_index.
236236
uint64 locations_length = 8;
237237
// A 128bit id that uniquely identifies this stacktrace, globally. Index into string table. [optional]
238-
uint32 stacktrace_id_index = 9;
238+
int64 stacktrace_id_index = 9;
239239
// The type and unit of each value is defined by the corresponding
240240
// entry in Profile.sample_type. All samples must have the same
241241
// number of values, the same as the length of Profile.sample_type.
@@ -355,7 +355,7 @@ message Location {
355355
bool is_folded = 5;
356356

357357
// Type of frame (e.g. kernel, native, python, hotspot, php). Index into string table.
358-
uint32 type_index = 6;
358+
int64 type_index = 6;
359359

360360
// References to attributes in Profile.attribute_table. [optional]
361361
repeated uint64 attributes = 7;

0 commit comments

Comments
 (0)