Skip to content

Commit 833a4eb

Browse files
authored
profiles: drop Sample.stacktrace_id_index (#575)
The value for Sample.stacktrace_id_index is hardly defined except for its length. It is also not defined how this value should be generated, interpreted and could be used. Some kind of stacktrace_id can be most efficient in stateful protocols, where transmitting duplicate information should be avoided. As the OTel Profiling protocol is a stateless protocol, this element can be droped.
1 parent f52dd5c commit 833a4eb

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

opentelemetry/proto/profiles/v1experimental/pprofextended.proto

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,6 @@ message Sample {
234234
// locations_length along with locations_start_index refers to a slice of locations in Profile.location.
235235
// Supersedes location_index.
236236
uint64 locations_length = 8;
237-
// A 128bit id that uniquely identifies this stacktrace, globally. Index into string table. [optional]
238-
uint32 stacktrace_id_index = 9;
239237
// The type and unit of each value is defined by the corresponding
240238
// entry in Profile.sample_type. All samples must have the same
241239
// number of values, the same as the length of Profile.sample_type.

0 commit comments

Comments
 (0)