Skip to content

Commit b03724a

Browse files
x13nbogdandrutu
andauthored
Allow negative bucket bounds in explicit_bounds (#163)
Fixes #156 @nilebox @bogdandrutu @jmacd Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
1 parent 1d26e52 commit b03724a

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

gen/go/metrics/v1/metrics.pb.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

opentelemetry/proto/metrics/v1/metrics.proto

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -373,14 +373,14 @@ message HistogramDataPoint {
373373
// This defines size(bounds) + 1 (= N) buckets. The boundaries for bucket
374374
// at index i are:
375375
//
376-
// [0, bounds[i]) for i == 0
376+
// (-infinity, bounds[i]) for i == 0
377377
// [bounds[i-1], bounds[i]) for 0 < i < N-1
378378
// [bounds[i], +infinity) for i == N-1
379-
// The values in bounds array must be strictly increasing and > 0.
379+
// The values in bounds array must be strictly increasing.
380380
//
381-
// Note: only [a, b) intervals are currently supported for each bucket. If we decides
382-
// to also support (a, b] intervals we should add support for these by defining a boolean
383-
// value which decides what type of intervals to use.
381+
// Note: only [a, b) intervals are currently supported for each bucket except the first one.
382+
// If we decide to also support (a, b] intervals we should add support for these by defining
383+
// a boolean value which decides what type of intervals to use.
384384
repeated double explicit_bounds = 7;
385385
}
386386

0 commit comments

Comments
 (0)