File tree Expand file tree Collapse file tree
util/opentelemetry-util-genai
src/opentelemetry/util/genai Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -111,9 +111,9 @@ def _get_embedding_span_name(invocation: EmbeddingInvocation) -> str:
111111
112112def _get_workflow_span_name (invocation : WorkflowInvocation ) -> str :
113113 """Get the span name for an Workflow invocation."""
114- operation_name = getattr ( invocation , " operation_name" , None ) or ""
115- name = getattr ( invocation , " name" , None ) or ""
116- return f"{ operation_name } { name } " . strip ()
114+ operation_name = invocation . operation_name
115+ name = invocation . name
116+ return f"{ operation_name } { name } " if name else operation_name
117117
118118
119119def _get_llm_messages_attributes_for_span (
Original file line number Diff line number Diff line change @@ -60,14 +60,23 @@ def test_start_workflow_creates_span(self) -> None:
6060
6161 def test_start_workflow_span_name (self ) -> None :
6262 invocation = WorkflowInvocation (
63- name = "my_pipeline" , operation_name = "run_pipeline"
63+ name = "my_pipeline"
6464 )
6565 self .handler .start (invocation )
6666 self .handler .stop (invocation )
6767
6868 spans = self ._get_finished_spans ()
6969 self .assertEqual (len (spans ), 1 )
70- self .assertEqual (spans [0 ].name , "run_pipeline my_pipeline" )
70+ self .assertEqual (spans [0 ].name , "invoke_workflow my_pipeline" )
71+
72+ def test_start_workflow_span_name_without_name (self ) -> None :
73+ invocation = WorkflowInvocation ()
74+ self .handler .start (invocation )
75+ self .handler .stop (invocation )
76+
77+ spans = self ._get_finished_spans ()
78+ self .assertEqual (len (spans ), 1 )
79+ self .assertEqual (spans [0 ].name , "invoke_workflow" )
7180
7281 def test_start_workflow_span_kind_is_internal (self ) -> None :
7382 invocation = WorkflowInvocation (name = "wf" )
You can’t perform that action at this time.
0 commit comments