Skip to content

Commit 494bf09

Browse files
authored
add a test for redis using NoOpTracerProvider (#1559)
1 parent 6d1550b commit 494bf09

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

  • instrumentation/opentelemetry-instrumentation-redis/tests

instrumentation/opentelemetry-instrumentation-redis/tests/test_redis.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
import redis
1717

18+
from opentelemetry import trace
1819
from opentelemetry.instrumentation.redis import RedisInstrumentor
1920
from opentelemetry.test.test_base import TestBase
2021
from opentelemetry.trace import SpanKind
@@ -146,3 +147,16 @@ def request_hook(span, conn, args, kwargs):
146147

147148
span = spans[0]
148149
self.assertEqual(span.attributes.get(custom_attribute_name), "GET")
150+
151+
def test_no_op_tracer_provider(self):
152+
RedisInstrumentor().uninstrument()
153+
tracer_provider = trace.NoOpTracerProvider
154+
RedisInstrumentor().instrument(tracer_provider=tracer_provider)
155+
156+
redis_client = redis.Redis()
157+
158+
with mock.patch.object(redis_client, "connection"):
159+
redis_client.get("key")
160+
161+
spans = self.memory_exporter.get_finished_spans()
162+
self.assertEqual(len(spans), 0)

0 commit comments

Comments
 (0)