lint updates

Author: keith-decker

util/opentelemetry-util-genai/src/opentelemetry/util/genai/metrics.py

@@ -62,7 +62,9 @@ def record(
                 )
         else:
             # ToolCall
-            attributes[GenAI.GEN_AI_OPERATION_NAME] = "execute_tool"
+            attributes[GenAI.GEN_AI_OPERATION_NAME] = (
+                GenAI.GenAiOperationNameValues.EXECUTE_TOOL.value
+            )
 
         # Common attributes across invocation types
         if invocation.provider:
@@ -95,7 +97,7 @@ def record(
                 context=span_context,
             )
 
-        # Token metrics only for LLMInvocation
+        # Token metrics for LLMInvocations.
         if isinstance(invocation, LLMInvocation):
             token_counts: list[tuple[int, str]] = []
             if invocation.input_tokens is not None:

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -393,7 +393,10 @@ def _apply_tool_call_attributes(
     - error.type (if operation ended in error)
     """
     # Set REQUIRED attribute
-    span.set_attribute(GenAI.GEN_AI_OPERATION_NAME, "execute_tool")
+    span.set_attribute(
+        GenAI.GEN_AI_OPERATION_NAME,
+        GenAI.GenAiOperationNameValues.EXECUTE_TOOL.value,
+    )
 
     # Set RECOMMENDED attributes (if present)
     if tool_call.name:
@@ -451,12 +454,6 @@ def _finish_tool_call_span(
     # Apply all attributes including result if available
     _apply_tool_call_attributes(span, tool_call, capture_content)
 
-    # Set status based on error presence
-    if tool_call.error_type:
-        span.set_status(Status(StatusCode.ERROR))
-    else:
-        span.set_status(Status(StatusCode.OK))
-
 
 __all__ = [
     "_apply_llm_finish_attributes",

util/opentelemetry-util-genai/tests/test_handler_metrics.py

@@ -271,9 +271,6 @@ def test_stop_tool_call_ends_span(self):
             "Get current weather",
         )
 
-        # Check status is OK
-        self.assertEqual(span.status.status_code, StatusCode.OK)
-
     def test_stop_tool_call_without_start(self):
         """Test stop without prior start is a no-op for ToolCall"""
         tool = ToolCall(name="test", arguments={}, id=None)
@@ -355,7 +352,6 @@ def test_tool_call_context_manager_success(self):
 
         span = spans[0]
         self.assertEqual(span.name, "execute_tool calculate_sum")
-        self.assertEqual(span.status.status_code, StatusCode.OK)
         self.assertEqual(
             span.attributes[GenAI.GEN_AI_TOOL_NAME], "calculate_sum"
         )