add additional tests

Signed-off-by: Artem Muterko <artem@sopho.tech>

Author: archy-rock3t-cloud

instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py

@@ -18,6 +18,9 @@
 from opentelemetry import trace as trace_api
 from opentelemetry.instrumentation.sqlite3 import SQLite3Instrumentor
 from opentelemetry.instrumentation.utils import suppress_instrumentation
+from opentelemetry.semconv._incubating.attributes.db_attributes import (
+    DB_STATEMENT,
+)
 from opentelemetry.test.test_base import TestBase
 
 
@@ -139,6 +142,7 @@ def test_uninstrument(self):
         SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
         cnx = self._connect()
         cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
         cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -149,6 +153,7 @@ def test_uninstrument(self):
 
         cnx2 = self._connect()
         cursor2 = cnx2.cursor()
+        self.addCleanup(cursor2.close)
         cursor2.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -160,6 +165,7 @@ def test_uninstrument_connection_with_instrument(self):
         cnx = self._connect()
         query = "CREATE TABLE IF NOT EXISTS test (id integer)"
         cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
         cursor.execute(query)
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -168,6 +174,7 @@ def test_uninstrument_connection_with_instrument(self):
         self.memory_exporter.clear()
         cnx = SQLite3Instrumentor.uninstrument_connection(cnx)
         cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
         cursor.execute(query)
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -180,6 +187,7 @@ def test_no_op_tracer_provider(self):
         )
         cnx = self._connect()
         cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
         cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -192,6 +200,7 @@ def test_suppress_instrumentation(self):
 
         with suppress_instrumentation():
             cursor = cnx.cursor()
+            self.addCleanup(cursor.close)
             cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
 
         spans_list = self.memory_exporter.get_finished_spans()
@@ -202,13 +211,18 @@ def test_span_failed(self):
         SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
         cnx = self._connect()
         cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
 
         with self.assertRaises(sqlite3.OperationalError):
             cursor.execute("SELECT * FROM nonexistent_table")
 
         spans_list = self.memory_exporter.get_finished_spans()
         self.assertEqual(len(spans_list), 1)
         span = spans_list[0]
+        self.assertEqual(
+            span.attributes[DB_STATEMENT],
+            "SELECT * FROM nonexistent_table",
+        )
         self.assertIs(span.status.status_code, trace_api.StatusCode.ERROR)
         self.assertEqual(
             span.status.description,