Skip to content

Commit 08808aa

Browse files
committed
Fix benchmarks
1 parent de9fed0 commit 08808aa

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

opentelemetry-sdk/benchmarks/trace/test_benchmark_trace.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
sampling,
2727
)
2828

29-
tracer = TracerProvider(
29+
tracer_provider = TracerProvider(
3030
sampler=sampling.DEFAULT_ON,
3131
resource=Resource(
3232
{
@@ -35,10 +35,11 @@
3535
"service.instance.id": "123ab456-a123-12ab-12ab-12340a1abc12",
3636
}
3737
),
38-
).get_tracer("sdk_tracer_provider")
38+
)
39+
tracer = tracer_provider.get_tracer("sdk_tracer_provider")
3940

4041

41-
@pytest.fixture(params=[None, 0, 1, 10, 50])
42+
@pytest.fixture(params=[0, 1, 10, 50])
4243
def num_tracer_configurator_rules(request):
4344
return request.param
4445

@@ -81,18 +82,13 @@ def tracer_configurator(tracer_scope):
8182
default_config=_TracerConfig(is_enabled=True),
8283
)(tracer_scope=tracer_scope)
8384

84-
tracer_provider = tracer._tracer_provider
8585
tracer_provider._set_tracer_configurator(
8686
tracer_configurator=tracer_configurator
8787
)
88-
if num_tracer_configurator_rules is None:
89-
tracer._tracer_provider = None
9088
benchmark(benchmark_start_span)
9189
tracer_provider._set_tracer_configurator(
9290
tracer_configurator=_default_tracer_configurator
9391
)
94-
if num_tracer_configurator_rules is None:
95-
tracer._tracer_provider = tracer_provider
9692

9793

9894
def test_simple_start_as_current_span(benchmark):

0 commit comments

Comments
 (0)