removed warning suppression comments and instead ignored the tests dir for TID252 rule check

JayeshHire · JayeshHire · commit 1809b73b749b · 2026-03-30T21:15:57.000+05:30
diff --git a/pyproject.toml b/pyproject.toml
@@ -95,6 +95,7 @@ ignore = [
 [tool.ruff.lint.per-file-ignores]
 "docs/**/*.*" = ["PLE"]
 "opentelemetry-sdk/tests/_configuration/test_models.py" = ["E402", "PLC0415"]
+"shim/opentelemetry-opentracing-shim/tests/*" = ["TID252"]
 
 [tool.ruff.lint.isort]
 known-third-party = [
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_asyncio.py
@@ -15,9 +15,9 @@
 import asyncio
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import stop_loop_when
 
 
 class TestAsyncio(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_threads.py
@@ -17,8 +17,8 @@
 )
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
 
 
 class TestThreads(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_asyncio.py
@@ -18,9 +18,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_logger, get_one_by_tag, stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_logger, get_one_by_tag, stop_loop_when
 
 logger = get_logger(__name__)
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_threads.py
@@ -19,9 +19,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import await_until, get_logger, get_one_by_tag  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import await_until, get_logger, get_one_by_tag
 
 logger = get_logger(__name__)
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/request_handler.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/request_handler.py
@@ -15,7 +15,7 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..utils import get_logger  # noqa: TID252
+from ..utils import get_logger
 
 logger = get_logger(__name__)
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_asyncio.py
@@ -17,9 +17,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_logger, get_one_by_operation_name, stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_logger, get_one_by_operation_name, stop_loop_when
 from .request_handler import RequestHandler
 
 logger = get_logger(__name__)
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_threads.py
@@ -19,9 +19,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_logger, get_one_by_operation_name  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_logger, get_one_by_operation_name
 from .request_handler import RequestHandler
 
 logger = get_logger(__name__)
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_asyncio.py
@@ -15,9 +15,9 @@
 import asyncio
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_logger, stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_logger, stop_loop_when
 
 logger = get_logger(__name__)
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_threads.py
@@ -18,8 +18,8 @@
 )
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
 
 
 class TestThreads(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_asyncio.py
@@ -17,9 +17,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_one_by_tag  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_one_by_tag
 from .response_listener import ResponseListener
 
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_threads.py
@@ -19,9 +19,9 @@
 from opentracing.ext import tags
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_one_by_tag  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_one_by_tag
 from .response_listener import ResponseListener
 
 
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_asyncio.py
@@ -16,9 +16,9 @@
 import random
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import get_logger, stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import get_logger, stop_loop_when
 
 random.seed()
 logger = get_logger(__name__)
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_threads.py
@@ -19,9 +19,9 @@
 )
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import RefCount, get_logger  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import RefCount, get_logger
 
 random.seed()
 logger = get_logger(__name__)
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_asyncio.py
@@ -15,9 +15,9 @@
 import asyncio
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import stop_loop_when  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import stop_loop_when
 
 
 class TestAsyncio(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_threads.py
@@ -17,9 +17,9 @@
 )
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
-from ..utils import await_until  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
+from ..utils import await_until
 
 
 class TestThreads(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_asyncio.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_asyncio.py
@@ -15,8 +15,8 @@
 import asyncio
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
 
 
 class TestAsyncio(OpenTelemetryTestCase):
diff --git a/shim/opentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_threads.py b/shim/opentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_threads.py
@@ -17,8 +17,8 @@
 )
 
 # pylint: disable=import-error
-from ..otel_ot_shim_tracer import MockTracer  # noqa: TID252
-from ..testcase import OpenTelemetryTestCase  # noqa: TID252
+from ..otel_ot_shim_tracer import MockTracer
+from ..testcase import OpenTelemetryTestCase
 
 
 class TestThreads(OpenTelemetryTestCase):

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,8 @@`
`17`	`17`	`)`
`18`	`18`
`19`	`19`	`# pylint: disable=import-error`
`20`		`-from ..otel_ot_shim_tracer import MockTracer # noqa: TID252`
`21`		`-from ..testcase import OpenTelemetryTestCase # noqa: TID252`
	`20`	`+from ..otel_ot_shim_tracer import MockTracer`
	`21`	`+from ..testcase import OpenTelemetryTestCase`
`22`	`22`
`23`	`23`
`24`	`24`	`class TestThreads(OpenTelemetryTestCase):`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@`
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`# pylint: disable=import-error`
`21`		`-from ..otel_ot_shim_tracer import MockTracer # noqa: TID252`
`22`		`-from ..testcase import OpenTelemetryTestCase # noqa: TID252`
	`21`	`+from ..otel_ot_shim_tracer import MockTracer`
	`22`	`+from ..testcase import OpenTelemetryTestCase`
`23`	`23`
`24`	`24`
`25`	`25`	`class TestThreads(OpenTelemetryTestCase):`