fix(metrics): guard _advisory access in ExplicitBucketHistogramAggregation for non-Histogram instruments

Author: giorgiovilardo

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

@@ -1390,7 +1390,12 @@ def _create_aggregation(
         if self._boundaries is not None:
             boundaries = self._boundaries
         else:
-            boundaries = instrument._advisory.explicit_bucket_boundaries
+            advisory = getattr(instrument, "_advisory", None)
+            boundaries = (
+                advisory.explicit_bucket_boundaries
+                if advisory is not None
+                else None
+            )
 
         return _ExplicitBucketHistogramAggregation(
             attributes,

opentelemetry-sdk/tests/metrics/test_aggregation.py

@@ -671,6 +671,21 @@ def test_observable_gauge(self):
         )
         self.assertIsInstance(aggregation, _LastValueAggregation)
 
+    def test_explicit_bucket_histogram_on_instrument_without_boundaries(self):
+        """ExplicitBucketHistogramAggregation should not crash when applied
+        to a non-Histogram instrument without explicit boundaries.
+
+        Regression test for https://github.com/open-telemetry/opentelemetry-python/issues/5009
+        """
+        aggregation = ExplicitBucketHistogramAggregation()
+        result = aggregation._create_aggregation(
+            _Counter("test.counter", Mock(), Mock()),
+            Mock(),
+            _default_reservoir_factory,
+            0,
+        )
+        self.assertIsInstance(result, _ExplicitBucketHistogramAggregation)
+
 
 class TestExemplarsFromAggregations(TestCase):
     def test_collection_simple_fixed_size_reservoir(self):