Apply suggestions from code review

Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Co-authored-by: alrex <alrex.boten@gmail.com>

Author: 3 people

ext/opentelemetry-ext-asgi/README.rst

@@ -8,7 +8,7 @@ OpenTelemetry ASGI Middleware
 
 
 This library provides a ASGI middleware that can be used on any ASGI framework
-(such as Django / Flask) to track requests timing through OpenTelemetry.
+(such as Django, Starlette, FastAPI or Quart) to track requests timing through OpenTelemetry.
 
 Installation
 ------------

ext/opentelemetry-ext-asgi/setup.cfg

@@ -23,7 +23,7 @@ url = https://github.com/open-telemetry/opentelemetry-python/ext/opentelemetry-e
 platforms = any
 license = Apache-2.0
 classifiers =
-    Development Status :: 3 - Alpha
+    Development Status :: 4 - Beta
     Intended Audience :: Developers
     License :: OSI Approved :: Apache Software License
     Programming Language :: Python

ext/opentelemetry-ext-asgi/setup.py

@@ -1,4 +1,4 @@
-# Copyright 2019, OpenTelemetry Authors
+# Copyright The OpenTelemetry Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

ext/opentelemetry-ext-asgi/src/opentelemetry/ext/asgi/__init__.py

@@ -1,4 +1,4 @@
-# Copyright 2019, OpenTelemetry Authors
+# Copyright The OpenTelemetry Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -81,15 +81,15 @@ def collect_request_attributes(scope):
     port = server[1]
     server_host = server[0] + (":" + str(port) if port != 80 else "")
     http_url = (
-        scope.get("scheme") + "://" + server_host + scope.get("path", "")
+        scope.get("scheme", "http") + "://" + server_host + scope.get("path", "")
         if scope.get("scheme") and server_host and scope.get("path")
         else None
     )
     if scope.get("query_string") and http_url:
         http_url = http_url + ("?" + scope.get("query_string").decode("utf8"))
 
     result = {
-        "component": scope.get("type"),
+        "component": scope["type"]
         "http.scheme": scope.get("scheme"),
         "http.host": server_host,
         "host.port": port,
@@ -186,14 +186,14 @@ async def wrapped_receive():
                     with self.tracer.start_as_current_span(
                         span_name + " asgi." + scope["type"] + ".receive"
                     ) as receive_span:
-                        payload = await receive()
+                        message = await receive()
                         if payload["type"] == "websocket.receive":
                             set_status_code(receive_span, 200)
                         receive_span.set_attribute("type", payload["type"])
                     return payload
 
                 @wraps(send)
-                async def wrapped_send(payload):
+                async def wrapped_send(message):
                     with self.tracer.start_as_current_span(
                         span_name + " asgi." + scope["type"] + ".send"
                     ) as send_span:

ext/opentelemetry-ext-asgi/src/opentelemetry/ext/asgi/version.py

@@ -1,4 +1,4 @@
-# Copyright 2019, OpenTelemetry Authors
+# Copyright The OpenTelemetry Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

ext/opentelemetry-ext-asgi/tests/test_asgi_middleware.py

@@ -1,4 +1,4 @@
-# Copyright 2019, OpenTelemetry Authors
+# Copyright The OpenTelemetry Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

tests/util/src/opentelemetry/test/asgitestutil.py

@@ -38,9 +38,9 @@ def tearDown(self):
     def seed_app(self, app):
         self.communicator = ApplicationCommunicator(app, self.scope)
 
-    def send_input(self, payload):
+    def send(self, message):
         asyncio.get_event_loop().run_until_complete(
-            self.communicator.send_input(payload)
+            self.communicator.send_input(message)
         )
 
     def send_default_request(self):