fix(metrics): guard _advisory access in ExplicitBucketHistogramAggregation for non-Histogram instruments

Author: giorgiovilardo

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

@@ -1390,7 +1390,13 @@ def _create_aggregation(
         if self._boundaries is not None:
             boundaries = self._boundaries
         else:
-            boundaries = instrument._advisory.explicit_bucket_boundaries
+            # guard for usage with instruments without advisory
+            advisory = getattr(instrument, "_advisory", None)
+            boundaries = (
+                advisory.explicit_bucket_boundaries
+                if advisory is not None
+                else None
+            )
 
         return _ExplicitBucketHistogramAggregation(
             attributes,

opentelemetry-sdk/tests/metrics/test_aggregation.py

@@ -476,6 +476,19 @@ def test_boundaries(self):
             ),
         )
 
+    def test_create_aggregation_on_instrument_without_boundaries(self):
+        """ExplicitBucketHistogramAggregation should not crash when applied
+        to a non-Histogram instrument without explicit boundaries.
+        """
+        aggregation = ExplicitBucketHistogramAggregation()
+        result = aggregation._create_aggregation(
+            _Counter("test.counter", Mock(), Mock()),
+            Mock(),
+            _default_reservoir_factory,
+            0,
+        )
+        self.assertIsInstance(result, _ExplicitBucketHistogramAggregation)
+
 
 class TestAggregationFactory(TestCase):
     def test_sum_factory(self):