diff --git a/CHANGELOG.md b/CHANGELOG.md index 54ad038d36..d7ef19ad23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +- Fix `BatchLogRecordProcessor` default `schedule_delay_millis` from 5000ms to 1000ms to comply with the OTel specification. Note: logs may be exported 5x more frequently by default (e.g. for users who don't explicitly set the `OTEL_BLRP_SCHEDULE_DELAY` env var). + ([#4998](https://github.com/open-telemetry/opentelemetry-python/pull/4998)) - `opentelemetry-sdk`: Add `process` resource detector support to declarative file configuration via `detection_development.detectors[].process` ([#5001](https://github.com/open-telemetry/opentelemetry-python/pull/5001)) - `opentelemetry-sdk`: Add shared `_parse_headers` helper for declarative config OTLP exporters diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py index 76889d881f..1c0f82ac05 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py @@ -52,7 +52,7 @@ OtelComponentTypeValues, ) -_DEFAULT_SCHEDULE_DELAY_MILLIS = 5000 +_DEFAULT_SCHEDULE_DELAY_MILLIS = 1000 _DEFAULT_MAX_EXPORT_BATCH_SIZE = 512 _DEFAULT_EXPORT_TIMEOUT_MILLIS = 30000 _DEFAULT_MAX_QUEUE_SIZE = 2048 diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py index edf91da3a6..4795e641e5 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py @@ -79,7 +79,7 @@ .. envvar:: OTEL_BLRP_SCHEDULE_DELAY The :envvar:`OTEL_BLRP_SCHEDULE_DELAY` represents the delay interval between two consecutive exports of the BatchLogRecordProcessor. -Default: 5000 +Default: 1000 """ OTEL_BLRP_EXPORT_TIMEOUT = "OTEL_BLRP_EXPORT_TIMEOUT" diff --git a/opentelemetry-sdk/tests/logs/test_export.py b/opentelemetry-sdk/tests/logs/test_export.py index a9dcd3a61d..c36eeccfdc 100644 --- a/opentelemetry-sdk/tests/logs/test_export.py +++ b/opentelemetry-sdk/tests/logs/test_export.py @@ -582,7 +582,7 @@ def test_args_defaults(self): log_record_processor._batch_processor._max_queue_size, 2048 ) self.assertEqual( - log_record_processor._batch_processor._schedule_delay, 5 + log_record_processor._batch_processor._schedule_delay, 1 ) self.assertEqual( log_record_processor._batch_processor._max_export_batch_size, 512 @@ -613,7 +613,7 @@ def test_args_env_var_value_error(self): log_record_processor._batch_processor._max_queue_size, 2048 ) self.assertEqual( - log_record_processor._batch_processor._schedule_delay, 5 + log_record_processor._batch_processor._schedule_delay, 1 ) self.assertEqual( log_record_processor._batch_processor._max_export_batch_size, 512 @@ -639,7 +639,7 @@ def test_args_none_defaults(self): log_record_processor._batch_processor._max_queue_size, 2048 ) self.assertEqual( - log_record_processor._batch_processor._schedule_delay, 5 + log_record_processor._batch_processor._schedule_delay, 1 ) self.assertEqual( log_record_processor._batch_processor._max_export_batch_size, 512