Skip to content

Commit 032213c

Browse files
dashpolejack-berg
andauthored
prometheus compatibility: clarify that the service triplet is required to be unique by semantic conventions (#3945)
Fixes #3944 OTLP does not include that requirement. Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
1 parent b4e6ec1 commit 032213c

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ release.
2828

2929
- Prometheus compatibility: Clarify naming of the target info metric, and differences between various Prometheus formats.
3030
([#3871](https://github.com/open-telemetry/opentelemetry-specification/pull/3871))
31+
- Prometheus compatibility: Clarify that the service triplet is required to be unique by semantic conventions.
32+
([#3945](https://github.com/open-telemetry/opentelemetry-specification/pull/3945))
3133

3234
### SDK Configuration
3335

specification/compatibility/prometheus_and_openmetrics.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,9 @@ formats do not include a notion of resource, and expect metric labels to
425425
distinguish scraped targets. By convention, [`job` and `instance`](https://prometheus.io/docs/concepts/jobs_instances/#jobs-and-instances)
426426
labels distinguish targets and are expected to be present on metrics exposed on
427427
a Prometheus pull exporter (a ["federated"](https://prometheus.io/docs/prometheus/latest/federation/)
428-
Prometheus endpoint) or pushed via Prometheus remote-write. In OTLP, the
429-
`service.name`, `service.namespace`, and `service.instance.id` triplet is
428+
Prometheus endpoint) or pushed via Prometheus remote-write. In OpenTelemetry
429+
semantic conventions, the `service.name`, `service.namespace`, and
430+
`service.instance.id` triplet is
430431
[required to be unique](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/README.md#service),
431432
which makes them good candidates to use to construct `job` and `instance`. In
432433
the collector Prometheus exporters, the `service.name` and `service.namespace`

0 commit comments

Comments
 (0)