Skip to content

Commit dbe4426

Browse files
tigrannajaryancarlosalberto
authored andcommitted
Allow omitting LogRecord in favor of build pattern in Logging SDKs (open-telemetry/oteps#183)
The discussion while implementing the Java SDK revealed that the LogRecord data type may not be necessary. See here open-telemetry/opentelemetry-java#3759 (comment) However, in some other languages LogRecord fits nicely (see the comment about Python implementation in the same comment thread). This changes allows implementators of the OTEP to choose the most idiomatic approach for their language.
1 parent fad8665 commit dbe4426

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

oteps/logs/0150-logging-library-sdk.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,12 @@ Methods:
7979
trace context related fields (TraceId,SpanId,TraceFlags) if applicable before
8080
making the call. Open Question: do we need to also pass the Baggage so that
8181
log processors and exporters can use it if they see the need?
82+
83+
Note: some languages may opt to avoid having a LogRecord data type and instead
84+
use a more idiomatic builder pattern to prepare and emit a log record (see
85+
e.g.
86+
[Java discussion](https://github.com/open-telemetry/opentelemetry-java/pull/3759#discussion_r738019425))
87+
8288
- Flush.
8389

8490
### LogRecord

0 commit comments

Comments
 (0)