Skip to content

Commit e0a5864

Browse files
traskpellared
andauthored
Add optional Exception parameter to Emit LogRecord (#4824)
Part of [OTEP 4430](https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4430-span-event-api-deprecation-plan.md). This could be considered "just a convenience", but (in addition to a very nice convenience) it also unlocks two additional features: - Performance optimization since the SDK can take `OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT` into consideration when generating large `exception.stacktrace` attributes (a very real issue in the Java world: open-telemetry/opentelemetry-java#7281) - (Future) customization of exception stacktraces (we have experimental support for this in Java, e.g. to support "smarter" truncation of long `exception.stacktrace` attributes: open-telemetry/opentelemetry-java#7266) Prototype: open-telemetry/opentelemetry-java#7182 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com>
1 parent abf1278 commit e0a5864

File tree

16 files changed

+44
-0
lines changed

16 files changed

+44
-0
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ release.
1818

1919
### Logs
2020

21+
- Add optional `Exception` parameter to Emit LogRecord.
22+
([#4824](https://github.com/open-telemetry/opentelemetry-specification/pull/4824))
23+
2124
### Baggage
2225

2326
### Profiles

spec-compliance-matrix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ Disclaimer: this list of features is still a work in progress, please refer to t
200200
| LoggerProvider.Shutdown | | + | + | + | + | + | | + | + | + | - | |
201201
| LoggerProvider.ForceFlush | | + | + | + | + | + | | + | + | + | - | |
202202
| Logger.Emit(LogRecord) | | + | + | + | + | + | | + | + | + | - | |
203+
| Logger.Emit(LogRecord) with Exception parameter | X | | | | | | | | | | | |
203204
| LogRecord.Set EventName | | + | | | | | | | + | + | | |
204205
| Logger.Enabled | X | + | | | | | | + | + | + | | |
205206
| Ergonomic API | X | | | | | | | | | | | |

spec-compliance-matrix/cpp.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '+'
364366
- name: Logger.Enabled

spec-compliance-matrix/dotnet.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '-'
360360
- name: Logger.Emit(LogRecord)
361361
status: '-'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

spec-compliance-matrix/erlang.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '?'
360360
- name: Logger.Emit(LogRecord)
361361
status: '?'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

spec-compliance-matrix/go.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '+'
364366
- name: Logger.Enabled

spec-compliance-matrix/java.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

spec-compliance-matrix/js.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

spec-compliance-matrix/php.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

spec-compliance-matrix/python.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@ sections:
359359
status: '+'
360360
- name: Logger.Emit(LogRecord)
361361
status: '+'
362+
- name: Logger.Emit(LogRecord) with Exception parameter
363+
status: '?'
362364
- name: LogRecord.Set EventName
363365
status: '?'
364366
- name: Logger.Enabled

0 commit comments

Comments
 (0)