[ro] feature /content/docs/concepts/glossary.md#8093
[ro] feature /content/docs/concepts/glossary.md#8093chalin merged 23 commits intoopen-telemetry:mainfrom
Conversation
|
@chalin Hi, is this last failed error for check links related to false positives? Most of the pages are not yet translated into Romanian, they are linked as per the English version. Please advise, thank you! |
Hi. No, these are real failures. If you inspect the log at https://github.com/open-telemetry/opentelemetry.io/actions/runs/18516852373/job/52769038456?pr=8093, you'll see that it's complaining about missing Header IDs (hashes): |
|
@chalin Hi, I'm trying to fix the Check Links errors, but the error details point me to some other languages files. I'm blocked in this PR and I'm not sure how to fix this. |
vitorvasc
left a comment
There was a problem hiding this comment.
Hi, @didiViking!
I can see what is happening here, there are a few things you should do to address the issue with the links, I'll leave some inline comments.
|
Feel free to reorder the headings alphabetically as well, it helps keep the glossary consistent and easier to navigate. 🙂 |
|
@vitorvasc Thank you for the tips and examples. Now I fixed all missing Header IDs and it's failing due to some Portuguese broken links. Any ideas? |
I don't see the Portuguese broken links in the history, could you share which ones you're referring to? From what I can see in the last run, there are still three remaining errors in |
I corrected "receptors" but both "distributions" and "signals" are in the plural form in this error but in singular form in the original Header. I tried adding both plural and singular forms and the CI/CD it's still complaining. |
|
@vitorvasc @theletterf |
|
@vitorvasc All checks passed, I added all original links at the bottom of the text. Could you please review? I still need to pass this through a Romanian content review. Thank you! |
vitorvasc
left a comment
There was a problem hiding this comment.
Added a few inline suggestions, that should cover all the link labels now. Let me know if you have any questions 🙂
chalin
left a comment
There was a problem hiding this comment.
LGTM. Will let @vitorvasc have a final say, as well as @open-telemetry/docs-ro-approvers.
|
LGTM! @IrinaKarantoniou can we have a final approval here? |
|
@vitorvasc LGTM |
Co-authored-by: Vitor Vasconcellos <[email protected]>
Co-authored-by: Vitor Vasconcellos <[email protected]>
Related to #8088