Skip to content

Commit 463f7be

Browse files
committed
Hmm, move CREATE_DATASET task back to storeChunk
not so great, but lets keep that for now
1 parent 372142f commit 463f7be

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

include/openPMD/RecordComponent.tpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,17 @@ RecordComponent::storeChunk(Offset o, Extent e, F &&createBuffer)
103103
"using storeChunk() (see RecordComponent::resetDataset()).");
104104
}
105105

106+
if (!written())
107+
{
108+
Parameter<Operation::CREATE_DATASET> dCreate(rc.m_dataset.value());
109+
dCreate.name = Attributable::get().m_writable.ownKeyWithinParent;
110+
IOHandler()->enqueue(IOTask(this, dCreate));
111+
112+
Parameter<Operation::SET_WRITTEN> sWritten;
113+
sWritten.target_status = true;
114+
IOHandler()->enqueue(IOTask(this, sWritten));
115+
}
116+
106117
Parameter<Operation::GET_BUFFER_VIEW> getBufferView;
107118
getBufferView.offset = o;
108119
getBufferView.extent = e;

src/RecordComponent.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,8 @@ RecordComponent &RecordComponent::resetDataset(Dataset d)
241241
rc.m_dataset->dtype != Datatype::UNDEFINED &&
242242
IOHandler()->m_seriesStatus != internal::SeriesStatus::Parsing)
243243
{
244-
// TODO: try getting flush_io_handler = false to run
245244
seriesFlush_impl</* flush_entire_series = */ false>(
246245
{FlushLevel::SkeletonOnly}, /* flush_io_handler = */ true);
247-
Parameter<Operation::CREATE_DATASET> dCreate(rc.m_dataset.value());
248-
dCreate.name = Attributable::get().m_writable.ownKeyWithinParent;
249-
IOHandler()->enqueue(IOTask(this, dCreate));
250246
}
251247
});
252248
if (written())

0 commit comments

Comments
 (0)