test: add BuildMissingScopeFixCommands and BuildPairingApprovalFixCommands tests (#145)

Add 15 unit tests covering the two public error-message builder methods on
OpenClawGatewayClient that previously had zero test coverage.

BuildMissingScopeFixCommands (10 tests):
- Null/empty/whitespace scope defaults to 'operator.write'
- Specific scope is preserved in output
- Empty _grantedOperatorScopes shows '(none reported by gateway)' placeholder
- Populated scopes are listed correctly
- _operatorDeviceId present vs absent (placeholder shown when missing)
- node.* scopes trigger 'node token' warning (case-insensitive match)
- Operator-only scopes produce no node-token warning

BuildPairingApprovalFixCommands (5 tests):
- _operatorDeviceId used when set
- Falls back to DeviceIdentity.DeviceId when _operatorDeviceId is null
- Empty scopes shows '(none reported by gateway yet)' placeholder
- Populated scopes are listed correctly
- Output always contains pairing approval instructions

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>

Author: github-actions[bot]

tests/OpenClaw.Shared.Tests/OpenClawGatewayClientTests.cs

@@ -227,6 +227,26 @@ private T GetPrivateField<T>(string fieldName)
                 System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
             return (T)(field!.GetValue(_client) ?? throw new InvalidOperationException($"Missing field value: {fieldName}"));
         }
+
+        public void SetGrantedScopes(string[] scopes) => SetPrivateField("_grantedOperatorScopes", scopes);
+
+        public void SetOperatorDeviceId(string? id) => SetPrivateField("_operatorDeviceId", id);
+
+        public string CallBuildMissingScopeFixCommands(string missingScope) =>
+            _client.BuildMissingScopeFixCommands(missingScope);
+
+        public string CallBuildPairingApprovalFixCommands() =>
+            _client.BuildPairingApprovalFixCommands();
+
+        public string GetFallbackDeviceId()
+        {
+            var identityField = typeof(OpenClawGatewayClient).GetField(
+                "_deviceIdentity",
+                System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
+            var identity = identityField!.GetValue(_client)!;
+            var deviceIdProp = identity.GetType().GetProperty("DeviceId");
+            return (string)deviceIdProp!.GetValue(identity)!;
+        }
     }
 
     private class TestLogger : IOpenClawLogger
@@ -813,4 +833,172 @@ public void ParseChannelHealth_StatusField_TakesPriorityOverDerivedStatus()
         Assert.Single(channels);
         Assert.Equal("degraded", channels[0].Status);
     }
+
+    // ── BuildMissingScopeFixCommands tests ─────────────────────────────────────
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_NullOrEmptyScope_DefaultsToOperatorWrite()
+    {
+        var helper = new GatewayClientTestHelper();
+
+        var output = helper.CallBuildMissingScopeFixCommands("");
+
+        Assert.Contains("Missing scope: operator.write", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WhitespaceScope_DefaultsToOperatorWrite()
+    {
+        var helper = new GatewayClientTestHelper();
+
+        var output = helper.CallBuildMissingScopeFixCommands("   ");
+
+        Assert.Contains("Missing scope: operator.write", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WithSpecificScope_IncludesItInOutput()
+    {
+        var helper = new GatewayClientTestHelper();
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.approvals");
+
+        Assert.Contains("Missing scope: operator.approvals", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_EmptyGrantedScopes_ShowsNoneReportedPlaceholder()
+    {
+        var helper = new GatewayClientTestHelper();
+        // _grantedOperatorScopes is empty by default
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("(none reported by gateway)", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WithGrantedScopes_ListsScopesInOutput()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetGrantedScopes(["operator.read", "operator.admin"]);
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("operator.read, operator.admin", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WithOperatorDeviceId_IncludesItInOutput()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetOperatorDeviceId("test-device-id-abc123");
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("test-device-id-abc123", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_NoOperatorDeviceId_ShowsNotReportedPlaceholder()
+    {
+        var helper = new GatewayClientTestHelper();
+        // _operatorDeviceId is null by default
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("(not reported for this operator connection)", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WithNodeScopes_ShowsNodeTokenWarning()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetGrantedScopes(["node.read", "node.write"]);
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("Detected node.* scopes", output);
+        Assert.Contains("node token", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_WithOnlyOperatorScopes_NoNodeTokenWarning()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetGrantedScopes(["operator.read", "operator.write"]);
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.DoesNotContain("node token", output);
+    }
+
+    [Fact]
+    public void BuildMissingScopeFixCommands_NodeScopeIsCaseInsensitive()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetGrantedScopes(["NODE.read"]);
+
+        var output = helper.CallBuildMissingScopeFixCommands("operator.write");
+
+        Assert.Contains("Detected node.* scopes", output);
+    }
+
+    // ── BuildPairingApprovalFixCommands tests ──────────────────────────────────
+
+    [Fact]
+    public void BuildPairingApprovalFixCommands_WithOperatorDeviceId_UsesItInOutput()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetOperatorDeviceId("operator-device-abc");
+
+        var output = helper.CallBuildPairingApprovalFixCommands();
+
+        Assert.Contains("operator-device-abc", output);
+    }
+
+    [Fact]
+    public void BuildPairingApprovalFixCommands_NoOperatorDeviceId_FallsBackToDeviceIdentity()
+    {
+        var helper = new GatewayClientTestHelper();
+        // _operatorDeviceId is null by default
+
+        var fallbackId = helper.GetFallbackDeviceId();
+        var output = helper.CallBuildPairingApprovalFixCommands();
+
+        Assert.Contains(fallbackId, output);
+    }
+
+    [Fact]
+    public void BuildPairingApprovalFixCommands_EmptyGrantedScopes_ShowsNoneYetPlaceholder()
+    {
+        var helper = new GatewayClientTestHelper();
+        // _grantedOperatorScopes is empty by default
+
+        var output = helper.CallBuildPairingApprovalFixCommands();
+
+        Assert.Contains("(none reported by gateway yet)", output);
+    }
+
+    [Fact]
+    public void BuildPairingApprovalFixCommands_WithGrantedScopes_ListsThemInOutput()
+    {
+        var helper = new GatewayClientTestHelper();
+        helper.SetGrantedScopes(["operator.read", "operator.pairing"]);
+
+        var output = helper.CallBuildPairingApprovalFixCommands();
+
+        Assert.Contains("operator.read, operator.pairing", output);
+    }
+
+    [Fact]
+    public void BuildPairingApprovalFixCommands_ContainsApprovalInstructions()
+    {
+        var helper = new GatewayClientTestHelper();
+
+        var output = helper.CallBuildPairingApprovalFixCommands();
+
+        Assert.Contains("pairing required", output);
+        Assert.Contains("Approve this Windows tray device ID", output);
+    }
 }