fix(arm,build): changing ubuntu version in ARM cstor-base image#310
Merged
vishnuitta merged 4 commits intomayadata-io:developfrom May 26, 2020
Merged
fix(arm,build): changing ubuntu version in ARM cstor-base image#310vishnuitta merged 4 commits intomayadata-io:developfrom
vishnuitta merged 4 commits intomayadata-io:developfrom
Conversation
Signed-off-by: mynktl <mayank.patel@mayadata.io>
mynktl
added
bug
vishnuitta
reviewed
May 15, 2020
docker/Dockerfile.base.arm64
Outdated
| # | ||
|
|
||
| FROM arm64v8/ubuntu:18.04 | ||
| FROM arm64v8/ubuntu:16.04 |
There was a problem hiding this comment.
how about using some fixed one like the way its done for amd? Below is for amd:
FROM openebs/cstor-ubuntu:xenial-20190515
There was a problem hiding this comment.
@mynktl -- can you try with this please. openebs/arm64v8-ubuntu:xenial-20200326
Member
Author
There was a problem hiding this comment.
Thank you @kmova for creating ARM image.
trivy scan result with above image is as below:
openebs/cstor-pool-arm64:ci (ubuntu 16.04)
==========================================
Total: 270 (UNKNOWN: 0, LOW: 227, MEDIUM: 43, HIGH: 0, CRITICAL: 0)Signed-off-by: mynktl <mayank.patel@mayadata.io>
vishnuitta
requested review from
kmova and
pawanpraka1
and removed request for
kmova
kmova
approved these changes
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
This PR is required to fix the issue openebs/openebs#3037.
We are building ARM images for cstor from ubuntu:18.04, which is using libjson-c.3, while we are building cstor binaries in travis ARM machine, which is using ubuntu:16.04. Due to this image conflict between host and docker, we are facing issue with libjson-c library, while running cstor arm image.
What this PR does?:
This PR changes docker file for ARM build, to user ubuntu version 16.04 from 18.04.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:
Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>Signed-off-by: mynktl mayank.patel@mayadata.io