Skip to content

chore(analytic, cherry-pick): send install event on nfs-provisioner start#110

Merged
kmova merged 1 commit intoopenebs-archive:v0.7.xfrom
mynktl:installation-analytic-7.0.x
Sep 15, 2021
Merged

chore(analytic, cherry-pick): send install event on nfs-provisioner start#110
kmova merged 1 commit intoopenebs-archive:v0.7.xfrom
mynktl:installation-analytic-7.0.x

Conversation

@mynktl
Copy link
Copy Markdown
Contributor

@mynktl mynktl commented Sep 15, 2021

Why is this PR required? What issue does it fix?:
Cherry-pick PR for #109

What this PR does?:
This PR enable nfs-provisioner to send Installation and Ping event

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: mayank <mayank.patel@mayadata.io>
@mynktl mynktl requested a review from kmova September 15, 2021 14:29
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #110 (a0362a5) into v0.7.x (23d4176) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.7.x     #110      +/-   ##
==========================================
- Coverage   46.97%   46.91%   -0.06%     
==========================================
  Files          29       29              
  Lines        2378     2381       +3     
==========================================
  Hits         1117     1117              
- Misses       1182     1185       +3     
  Partials       79       79              
Impacted Files Coverage Δ
provisioner/controller.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d4176...a0362a5. Read the comment docs.

@kmova kmova merged commit c14c51b into openebs-archive:v0.7.x Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants