feat(k8s): add support for ImagePullSecret in NFS Server Pods#114
Merged
mynktl merged 2 commits intoopenebs-archive:developfrom Sep 22, 2021
Merged
feat(k8s): add support for ImagePullSecret in NFS Server Pods#114mynktl merged 2 commits intoopenebs-archive:developfrom
mynktl merged 2 commits intoopenebs-archive:developfrom
Conversation
This commit modifies the Helm chart as well as the provisioner itself to allow an ImagePullSecret for the NFS Server Pods to be passed in through an environment variable. Signed-off-by: Grant Linville <grantlinville@posteo.us>
mynktl
reviewed
Sep 21, 2021
Contributor
mynktl
left a comment
mynktl
left a comment
There was a problem hiding this comment.
@g-linville
Thanks for the PR. There is one small change required to move helm changes to separate PR. Rest Changes look good.
Signed-off-by: Grant Linville <grantlinville@posteo.us>
g-linville
added a commit
to g-linville/dynamic-nfs-provisioner
that referenced
this pull request
Sep 21, 2021
…ve#114 Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <grantlinville@posteo.us>
8 tasks
Contributor
Author
mynktl
approved these changes
Sep 22, 2021
Codecov Report
@@ Coverage Diff @@
## develop #114 +/- ##
===========================================
+ Coverage 46.97% 47.11% +0.14%
===========================================
Files 29 29
Lines 2378 2390 +12
===========================================
+ Hits 1117 1126 +9
- Misses 1182 1185 +3
Partials 79 79
Continue to review full report at Codecov.
|
g-linville
added a commit
to g-linville/dynamic-nfs-provisioner
that referenced
this pull request
Sep 22, 2021
…ve#114 Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <grantlinville@posteo.us>
8 tasks
mynktl
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the Helm chart as well as the
provisioner itself to allow an ImagePullSecret for
the NFS Server Pods to be passed in through an
environment variable.
Signed-off-by: Grant Linville grantlinville@posteo.us
Pull Request template
Why is this PR required? What issue does it fix?:
This fixes issue #113.
What this PR does?:
It add support to use an image pull secret in the NFS Server, allowing users to pull an image for it from a private container registry.
Does this PR require any upgrade changes?:
Not to my knowledge. If there is no image pull secret specified as an environment variable, the default of an empty string is used, which is ignored later on when the NFS Server Deployment is created.
If the changes in this PR are manually verified, list down the scenarios covered::
I added a test for the change that I made to the podtemplatespec and that (along with all the other tests) passed, but I have done no verification beyond that.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Nope!
Checklist:
<type>(<scope>): <subject>