feat: Add Original PVC context to the deployment labels.#151
Merged
niladrih merged 1 commit intoopenebs-archive:developfrom Feb 9, 2023
Merged
feat: Add Original PVC context to the deployment labels.#151niladrih merged 1 commit intoopenebs-archive:developfrom
niladrih merged 1 commit intoopenebs-archive:developfrom
Conversation
Signed-off-by: Vladimir Pouzanov <farcaller@gmail.com>
|
@abhilashshetty04 Sorry to bother ya'll, -- this is a really useful feature, is it possible to merge & release it? |
Contributor
Member
|
Thank you for the PR @farcaller. And thanks for the bump @t3hmrman. The CI checks seem to have not run, I'm putting the do-not-merge label on this one for a while. |
niladrih
approved these changes
Feb 9, 2023
Member
niladrih
left a comment
There was a problem hiding this comment.
Not sure what went wrong with the CI here, manual runs seem to pass. Accepted!
niladrih
added a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
This allows targeting the nfs workload pod using stable labels in e.g.
CiliumNetworkPolicyrules. Currently the only label on the workload isopenebs.io/nfs-serverwith the generated pvc name which cannot be deduced statically from the original pvc name.What this PR does?:
Adds the name/namespace/id labels to the pod.
Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Using the pod in the
CiliumNetworkPolicy, by targeting the new labels.Any additional information for your reviewer? :
N/A
Checklist:
<type>(<scope>): <subject>