fix(install): remove old castemplates and runtask after upgrade#1595
Merged
vishnuitta merged 4 commits intoopenebs-archive:masterfrom Jan 29, 2020
Merged
fix(install): remove old castemplates and runtask after upgrade#1595vishnuitta merged 4 commits intoopenebs-archive:masterfrom
vishnuitta merged 4 commits intoopenebs-archive:masterfrom
Conversation
mynktl
suggested changes
Jan 28, 2020
Contributor
There was a problem hiding this comment.
Thanks @shubham14bajpai for the PR. Changes looks good to me. I have one concern about cleanup error, is it ok to ignore the error?
mynktl
reviewed
Jan 28, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
shubham14bajpai
force-pushed
the
runtask
branch
from
0279984 to
63d3ed7
Compare
mynktl
reviewed
Jan 28, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
AmitKumarDas
approved these changes
Jan 29, 2020
mynktl
approved these changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does / why we need it:
The installer code currently does not clean up the old runtasks and castemplates after each upgrade. This causes lots of stale CRs after each upgrade.
Note: This PR removes old castemplates and runtasks for jiva 0.6.0 from installer code.
For example :
shovan@probot:~/Desktop/workspace$ kubectl get runtask -n openebs NAME AGE cas-volume-stats-default-0.9.0 220d cas-volume-stats-default-1.0.0 215d cas-volume-stats-default-1.1.0 175d cas-volume-stats-default-1.3.0 99d cas-volume-stats-default-1.4.0 71d cas-volume-stats-default-1.5.0 40d cas-volume-stats-default-1.6.0 7d cas-volume-stats-output-default-0.9.0 220d cas-volume-stats-output-default-1.0.0 215d cas-volume-stats-output-default-1.1.0 175d cas-volume-stats-output-default-1.3.0 99d cas-volume-stats-output-default-1.4.0 71d cas-volume-stats-output-default-1.5.0 40d cas-volume-stats-output-default-1.6.0 7d cstor-pool-create-getspc-default-0.9.0 220d cstor-pool-create-getspc-default-1.0.0 215d cstor-pool-create-getspc-default-1.1.0 175d cstor-pool-create-getspc-default-1.3.0 99d cstor-pool-create-getspc-default-1.4.0 71d cstor-pool-create-getspc-default-1.5.0 40d cstor-pool-create-getspc-default-1.6.0 7dshovan@probot:~/Desktop/workspace$ kubectl get cast NAME AGE cas-volume-stats-default-0.8.0 1y cas-volume-stats-default-0.8.1 334d cas-volume-stats-default-0.9.0 244d cas-volume-stats-default-1.0.0 215d cas-volume-stats-default-1.1.0 175d cas-volume-stats-default-1.3.0 99d cas-volume-stats-default-1.4.0 71d cas-volume-stats-default-1.5.0 40d cas-volume-stats-default-1.6.0 7dThis PR adds the Clean() to remove all the old CRs after the successful installation of latest CRs.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag