Collapse UpgradeDockerImageVersion cartesian via ChangeFrom capture (#1060)

`getRecipeList()` previously emitted one `ChangeFrom` per (image,
oldVersion, suffix) triple because `ChangeFrom.newTag` was a literal
string with no template support. ~35 hard-coded suffixes × 10 image
families × (version - 8) version steps produced 3,150 children per
invocation at version=17 and 5,950 at version=25.

`ChangeFrom` now supports glob `*` capture and `$N` backref substitution
in its new* fields. Replace the suffix enumeration with a single
`oldTag = "<oldVersion>*"` + `newTag = "<version>$1"` recipe per
(image, oldVersion) pair. `$1` carries whatever follows the old version
digits (may be empty, `-jdk-alpine`, `-jre-noble`, or any arbitrary
suffix), so the rewrite preserves the full OS/jdk/jre variant without
enumerating it in advance.

Per-invocation child count drops from ~3,150 -> ~90 at version=17
(35x), and from ~5,950 -> ~170 at version=25. Add two parameterized
test cases exercising an exotic suffix that previously only survived
the now-removed wildcard fallback (and lost its suffix).

Author: jkschneider

src/main/java/org/openrewrite/java/migrate/UpgradeDockerImageVersion.java

@@ -33,71 +33,34 @@ public class UpgradeDockerImageVersion extends Recipe {
             example = "11")
     Integer version;
 
+    private static final String[] DEPRECATED_IMAGES = {"openjdk", "adoptopenjdk"};
+    private static final String[] CURRENT_IMAGES = {
+            "eclipse-temurin", "amazoncorretto", "azul/zulu-openjdk",
+            "bellsoft/liberica-openjdk-debian", "bellsoft/liberica-openjdk-alpine",
+            "bellsoft/liberica-openjdk-centos", "ibm-semeru-runtimes", "sapmachine"
+    };
+
     String displayName = "Upgrade Docker image Java version";
     String description = "Upgrade Docker image tags to use the specified Java version. " +
             "Updates common Java Docker images including eclipse-temurin, amazoncorretto, azul/zulu-openjdk, " +
-            "and others. Also migrates deprecated images (openjdk, adoptopenjdk) to eclipse-temurin.";
+            "and others. Also migrates deprecated images (openjdk, adoptopenjdk) to eclipse-temurin. " +
+            "Uses a single `ChangeFrom` glob capture per (image, oldVersion) to preserve any tag suffix.";
 
     @Override
     public List<Recipe> getRecipeList() {
         List<Recipe> recipes = new ArrayList<>();
-        if (version == null) { // for uninitialized version
+        if (version == null) {
             return recipes;
         }
-        // Deprecated images -> migrate to eclipse-temurin
-        String[] deprecatedImages = {"openjdk", "adoptopenjdk"};
-        String[] currentImages = {
-                "eclipse-temurin", "amazoncorretto", "azul/zulu-openjdk",
-                "bellsoft/liberica-openjdk-debian", "bellsoft/liberica-openjdk-alpine",
-                "bellsoft/liberica-openjdk-centos", "ibm-semeru-runtimes", "sapmachine"
-        };
-        // Common tag suffixes to preserve when upgrading current images
-        // Longer suffixes must come before shorter ones to match correctly
-        String[] commonSuffixes = {
-                // Alpine
-                "-jdk-alpine", "-jre-alpine",
-                // Ubuntu LTS
-                "-jdk-noble", "-jre-noble",
-                "-jdk-jammy", "-jre-jammy",
-                "-jdk-focal", "-jre-focal",
-                "-jdk-bionic", "-jre-bionic",
-                // Debian
-                "-jdk-slim-bookworm", "-jre-slim-bookworm",
-                "-jdk-slim-bullseye", "-jre-slim-bullseye",
-                "-jdk-slim-buster", "-jre-slim-buster",
-                "-jdk-bookworm", "-jre-bookworm",
-                "-jdk-bullseye", "-jre-bullseye",
-                "-jdk-buster", "-jre-buster",
-                // Other Linux
-                "-jdk-centos7", "-jre-centos7",
-                "-jdk-ubi9-minimal", "-jre-ubi9-minimal",
-                // Windows
-                "-jdk-nanoserver", "-jre-nanoserver",
-                "-jdk-windowsservercore", "-jre-windowsservercore",
-                // Generic suffixes (must come last)
-                "-alpine", "-slim",
-                "-jdk", "-jre"
-        };
+        String newVer = version.toString();
         for (int oldVersion = 8; oldVersion < version; oldVersion++) {
-            // Deprecated images: match specific suffixes first to preserve them
-            for (String image : deprecatedImages) {
-                for (String suffix : commonSuffixes) {
-                    recipes.add(new ChangeFrom(image, oldVersion + suffix, null, null, "eclipse-temurin", version + suffix, null, null));
-                }
-            }
-            // Deprecated images: fall back to wildcard for remaining patterns
-            for (String image : deprecatedImages) {
-                recipes.add(new ChangeFrom(image, oldVersion + "*", null, null, "eclipse-temurin", version.toString(), null, null));
-            }
-            // Current images: match specific suffixes first to preserve them
-            for (String image : currentImages) {
-                for (String suffix : commonSuffixes) {
-                    recipes.add(new ChangeFrom(image, oldVersion + suffix, null, null, null, version + suffix, null, null));
-                }
+            String oldTag = oldVersion + "*";
+            String newTag = newVer + "$1";
+            for (String image : DEPRECATED_IMAGES) {
+                recipes.add(new ChangeFrom(image, oldTag, null, null, "eclipse-temurin", newTag, null, null));
             }
-            // Current images: fall back to wildcard for remaining patterns
-            for (String image : currentImages) {
-                recipes.add(new ChangeFrom(image, oldVersion + "*", null, null, null, version.toString(), null, null));
+            for (String image : CURRENT_IMAGES) {
+                recipes.add(new ChangeFrom(image, oldTag, null, null, null, newTag, null, null));
             }
         }
         return recipes;

src/test/java/org/openrewrite/java/migrate/UpgradeDockerImageVersionTest.java

@@ -47,6 +47,9 @@ class UpgradeDockerImageVersionTest implements RewriteTest {
       "eclipse-temurin, 11-jdk-focal, eclipse-temurin, 17-jdk-focal, 17",
       "amazoncorretto, 11-alpine, amazoncorretto, 17-alpine, 17",
       "azul/zulu-openjdk, 11-jdk, azul/zulu-openjdk, 17-jdk, 17",
+      // Arbitrary suffix preserved via $1 capture (previously lost through wildcard fallback)
+      "openjdk, 11-jdk-custom-suffix, eclipse-temurin, 17-jdk-custom-suffix, 17",
+      "eclipse-temurin, 11-jdk-custom-suffix, eclipse-temurin, 17-jdk-custom-suffix, 17",
     })
     @ParameterizedTest
     void upgradeDockerImage(String fromImage, String fromTag, String toImage, String toTag, int targetVersion) {