Skip InstanceOfPatternMatch for try-with-resources casts (#847)

Author: timtebeek

src/main/java/org/openrewrite/staticanalysis/InstanceOfPatternMatch.java

@@ -198,7 +198,8 @@ public void registerTypeCast(J.TypeCast typeCast, Cursor cursor) {
                 for (Iterator<?> it = cursor.getPath(); it.hasNext(); ) {
                     Object next = it.next();
                     if (validContexts.contains(next)) {
-                        if (isAcceptableTypeCast(typeCast.getType()) && isTheSameAsOtherTypeCasts(typeCast, instanceOf) && isAcceptableParentTypeCast(parent)) {
+                        if (isAcceptableTypeCast(typeCast.getType()) && isTheSameAsOtherTypeCasts(typeCast, instanceOf) && isAcceptableParentTypeCast(parent) &&
+                                cursor.firstEnclosing(J.Try.Resource.class) == null) {
                             if (parent.getValue() instanceof J.VariableDeclarations.NamedVariable &&
                                     !variablesToDelete.containsKey(instanceOf)) {
                                 variablesToDelete.put(instanceOf, new VariableAndTypeTree(parent.getValue(),

src/test/java/org/openrewrite/staticanalysis/InstanceOfPatternMatchTest.java

@@ -1766,4 +1766,28 @@ Throwable wrap(Throwable cause) {
             ), 17)
         );
     }
+
+    @Issue("https://github.com/openrewrite/rewrite/issues/4173")
+    @Test
+    void unchangedTryWithResourcesCast() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import java.io.Closeable;
+
+              class A {
+                  void foo(Object object) {
+                      if (object instanceof Closeable) {
+                          try (Closeable c = (Closeable) object) {
+                              System.out.println(c);
+                          } catch (Exception e) {
+                          }
+                      }
+                  }
+              }
+              """
+          )
+        );
+    }
 }