fix(javascript): support member renaming for aliased imports in ChangeImport (#7102)

* test replicated and passing

* testing scenario on failing case

Author: danne-jm

rewrite-javascript/rewrite/src/javascript/recipes/change-import.ts

@@ -14,13 +14,13 @@
  * limitations under the License.
  */
 
-import {Option, Recipe} from "../../recipe";
-import {TreeVisitor} from "../../visitor";
-import {ExecutionContext} from "../../execution";
-import {JavaScriptVisitor, JS} from "../index";
-import {maybeAddImport} from "../add-import";
-import {J, isIdentifier, Type} from "../../java";
-import {create as produce, Draft} from "mutative";
+import { Option, Recipe } from "../../recipe";
+import { TreeVisitor } from "../../visitor";
+import { ExecutionContext } from "../../execution";
+import { JavaScriptVisitor, JS } from "../index";
+import { maybeAddImport } from "../add-import";
+import { J, isIdentifier, Type } from "../../java";
+import { create as produce, Draft } from "mutative";
 
 /**
  * Changes an import from one module to another, updating all type attributions.
@@ -223,6 +223,13 @@ export class ChangeImport extends Recipe {
                                     if (specifier.specifier.kind === J.Kind.Identifier &&
                                         specifier.specifier.simpleName === oldMember) {
                                         specifier.specifier.simpleName = newMember;
+                                    } else if (specifier.specifier.kind === JS.Kind.Alias) {
+                                        const aliasNode = specifier.specifier as Draft<JS.Alias>;
+                                        const propertyName = aliasNode.propertyName.element;
+                                        if (propertyName.kind === J.Kind.Identifier &&
+                                            propertyName.simpleName === oldMember) {
+                                            propertyName.simpleName = newMember;
+                                        }
                                     }
                                 }
                             }
@@ -520,7 +527,7 @@ export class ChangeImport extends Recipe {
 
                         // Also update the method name if we're renaming the member
                         const updatedName = (oldMember !== 'default' && oldMember !== '*' &&
-                                            methodType.name === oldMember && newMember !== oldMember)
+                            methodType.name === oldMember && newMember !== oldMember)
                             ? newMember
                             : methodType.name;
 

rewrite-javascript/rewrite/test/javascript/recipes/change-import.test.ts

@@ -13,9 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import {RecipeSpec} from "../../../src/test";
-import {ChangeImport, npm, packageJson, tsx, typescript} from "../../../src/javascript";
-import {withDir} from "tmp-promise";
+import { RecipeSpec } from "../../../src/test";
+import { ChangeImport, npm, packageJson, tsx, typescript } from "../../../src/javascript";
+import { withDir } from "tmp-promise";
 
 describe("change-import", () => {
     describe("named imports", () => {
@@ -52,7 +52,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("changes named import with double quotes", async () => {
@@ -88,7 +88,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("preserves other imports from the same module", async () => {
@@ -127,7 +127,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("does not change import from different module", async () => {
@@ -157,7 +157,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("does not change unrelated imports from the same module", async () => {
@@ -188,7 +188,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("adds import from target module", async () => {
@@ -228,7 +228,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
 
         test("preserves aliased import", async () => {
@@ -264,7 +264,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
     });
 
@@ -299,7 +299,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
     });
 
@@ -334,7 +334,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
     });
 
@@ -370,7 +370,68 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
+        });
+
+        test("renames aliased member when changing import", async () => {
+            const spec = new RecipeSpec();
+            spec.recipe = new ChangeImport({
+                oldModule: "lodash",
+                oldMember: "extend",
+                newModule: "lodash",
+                newMember: "assign"
+            });
+
+            await withDir(async (repo) => {
+                await spec.rewriteRun(
+                    npm(
+                        repo.path,
+                        typescript(
+                            `
+                            import { extend as myExtend } from 'lodash';
+                            `,
+                            `
+                            import { assign as myExtend } from 'lodash';
+                            `
+                        ),
+                        packageJson(`{
+                            "name": "test",
+                            "dependencies": {
+                                "lodash": "^4.17.21"
+                            }
+                        }`)
+                    )
+                );
+            }, { unsafeCleanup: true });
+        });
+
+        test("does not rename if member is local alias only", async () => {
+            const spec = new RecipeSpec();
+            spec.recipe = new ChangeImport({
+                oldModule: "lodash",
+                oldMember: "extend",
+                newModule: "lodash",
+                newMember: "assign"
+            });
+
+            await withDir(async (repo) => {
+                await spec.rewriteRun(
+                    npm(
+                        repo.path,
+                        typescript(
+                            `
+                             import { flatten as extend } from 'lodash';
+                             `
+                        ),
+                        packageJson(`{
+                             "name": "test",
+                             "dependencies": {
+                                 "lodash": "^4.17.21"
+                             }
+                         }`)
+                    )
+                );
+            }, { unsafeCleanup: true });
         });
     });
 
@@ -414,7 +475,7 @@ describe("change-import", () => {
                         }`)
                     )
                 );
-            }, {unsafeCleanup: true});
+            }, { unsafeCleanup: true });
         });
     });
 });