Altering check for AddDependency to compare versions differently when direct vs indirect dependency. (#6505)

* If transitive, actually just allow regardless of version, as per old behaviour.

Author: steve-aom-elliott

rewrite-maven/src/main/java/org/openrewrite/maven/AddDependency.java

@@ -30,6 +30,7 @@
 import org.openrewrite.maven.tree.ResolvedGroupArtifactVersion;
 import org.openrewrite.maven.tree.Scope;
 import org.openrewrite.semver.Semver;
+import org.openrewrite.semver.VersionComparator;
 import org.openrewrite.xml.tree.Xml;
 
 import java.util.*;
@@ -219,14 +220,17 @@ public Xml visitDocument(Xml.Document document, ExecutionContext ctx) {
                     return maven;
                 }
 
+                VersionComparator vc = requireNonNull(Semver.validate(version, versionPattern).getValue());
+
                 // If the dependency is already in compile scope it will be available everywhere, no need to continue
                 Map<Scope, List<ResolvedDependency>> dependencies = getResolutionResult().getDependencies();
                 if (dependencies.get(Scope.Compile) != null) {
                     for (ResolvedDependency d : dependencies.get(Scope.Compile)) {
                         if (hasAcceptableTransitivity(d, acc) &&
                             groupId.equals(d.getGroupId()) &&
                             artifactId.equals(d.getArtifactId()) &&
-                            version.equals(d.getVersion())
+                            (d.isTransitive() ||
+                                    (d.isDirect() && version.equals(d.getVersion())))
                         ) {
                             return maven;
                         }