Skip to content

Commit 1e68ab3

Browse files
committed
Simplify version selection and collapse outer try/finally
1 parent c3a6bbd commit 1e68ab3

1 file changed

Lines changed: 17 additions & 19 deletions

File tree

rewrite-gradle-tooling-model/model/src/main/java/org/openrewrite/gradle/toolingapi/OpenRewriteModelBuilder.java

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -117,29 +117,27 @@ public static OpenRewriteModel forProjectDirectory(File projectDir, @Nullable Fi
117117
arguments.add(buildFile.getAbsolutePath());
118118
}
119119
}
120-
try {
121-
try (ProjectConnection connection = connector.connect()) {
122-
ModelBuilder<OpenRewriteModelProxy> customModelBuilder = connection.model(OpenRewriteModelProxy.class);
123-
if (initScript == null) {
124-
if (System.getProperty("org.openrewrite.gradle.local.use-embedded-classpath") != null) {
125-
// code path only expected to be taken from within openrewrite/rewrite
126-
String generatedInitScript = generateInitScriptFromManifest();
127-
Files.write(init, generatedInitScript.getBytes(StandardCharsets.UTF_8));
128-
} else {
129-
// Use default init.gradle from resources
130-
try (InputStream is = OpenRewriteModel.class.getResourceAsStream("/init.gradle")) {
131-
if (is == null) {
132-
throw new IllegalStateException("Expected to find init.gradle on the classpath");
133-
}
134-
Files.copy(is, init);
120+
try (ProjectConnection connection = connector.connect()) {
121+
ModelBuilder<OpenRewriteModelProxy> customModelBuilder = connection.model(OpenRewriteModelProxy.class);
122+
if (initScript == null) {
123+
if (System.getProperty("org.openrewrite.gradle.local.use-embedded-classpath") != null) {
124+
// code path only expected to be taken from within openrewrite/rewrite
125+
String generatedInitScript = generateInitScriptFromManifest();
126+
Files.write(init, generatedInitScript.getBytes(StandardCharsets.UTF_8));
127+
} else {
128+
// Use default init.gradle from resources
129+
try (InputStream is = OpenRewriteModel.class.getResourceAsStream("/init.gradle")) {
130+
if (is == null) {
131+
throw new IllegalStateException("Expected to find init.gradle on the classpath");
135132
}
133+
Files.copy(is, init);
136134
}
137-
} else {
138-
Files.write(init, initScript.getBytes());
139135
}
140-
customModelBuilder.withArguments(arguments);
141-
return OpenRewriteModel.from(customModelBuilder.get());
136+
} else {
137+
Files.write(init, initScript.getBytes());
142138
}
139+
customModelBuilder.withArguments(arguments);
140+
return OpenRewriteModel.from(customModelBuilder.get());
143141
} finally {
144142
try {
145143
if (Files.exists(init)) {

0 commit comments

Comments
 (0)