Skip to content

Commit 20ae3aa

Browse files
committed
Use exclusion-scoped patterns in test assertions
Tighten pattern assertions to match within <exclusion> tags so they don't accidentally match on direct dependency coordinates.
1 parent 29d6b70 commit 20ae3aa

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3532,13 +3532,11 @@ void exclusionPreservedAndSiblingAddedWhenDependencyGroupIdChanges() {
35323532
""",
35333533
spec -> spec.after(actual -> assertThat(actual)
35343534
// Old exclusion preserved
3535-
.contains("<groupId>com.fasterxml.jackson.jaxrs</groupId>")
3536-
.contains("<artifactId>jackson-jaxrs-json-provider</artifactId>")
3535+
.containsPattern("<exclusion>\\s*<groupId>com\\.fasterxml\\.jackson\\.jaxrs</groupId>\\s*<artifactId>jackson-jaxrs-json-provider</artifactId>\\s*</exclusion>")
35373536
// Sibling exclusion added for new coordinates
3538-
.contains("<groupId>com.fasterxml.jackson.jakarta.rs</groupId>")
3539-
.contains("<artifactId>jackson-jakarta-rs-json-provider</artifactId>")
3537+
.containsPattern("<exclusion>\\s*<groupId>com\\.fasterxml\\.jackson\\.jakarta\\.rs</groupId>\\s*<artifactId>jackson-jakarta-rs-json-provider</artifactId>\\s*</exclusion>")
35403538
// Version updated
3541-
.containsPattern("<version>2\\.\\d+\\.\\d+</version>")
3539+
.containsPattern("<groupId>com\\.fasterxml\\.jackson\\.jakarta\\.rs</groupId>\\s*<artifactId>jackson-jakarta-rs-json-provider</artifactId>\\s*<version>2\\.\\d+\\.\\d+</version>")
35423540
.doesNotContain("<version>2.9.7</version>")
35433541
.actual())
35443542
)

0 commit comments

Comments
 (0)