Make AddProfile idempotent by comparing existing profile content (#7355) (#7356)

AddProfile unconditionally removed and re-added a profile with the same
id on every recipe cycle. Use SemanticallyEqual to compare the existing
profile to the desired one and return early when they already match.

Author: timtebeek

rewrite-maven/src/main/java/org/openrewrite/maven/AddProfile.java

@@ -24,6 +24,7 @@
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.xml.AddToTagVisitor;
 import org.openrewrite.xml.RemoveContentVisitor;
+import org.openrewrite.xml.SemanticallyEqual;
 import org.openrewrite.xml.tree.Xml;
 
 import java.util.Optional;
@@ -84,29 +85,32 @@ public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) {
                     profiles = t.getChild("profiles").get();
                 }
 
+                Xml.Tag profileTag = Xml.Tag.build("<profile>\n" +
+                                                   "<id>" + id + "</id>\n" +
+                                                   (activation != null ? activation.trim() + "\n" : "") +
+                                                   (properties != null ? properties.trim() + "\n" : "") +
+                                                   (build != null ? build.trim() + "\n" : "") +
+                                                   "</profile>");
+
                 Optional<Xml.Tag> maybeProfile = profiles.getChildren().stream()
                         .filter(profile ->
                                 profile.getChildValue("id").get().equals(id)
                         )
                         .findAny();
 
                 if (maybeProfile.isPresent()) {
-                    Xml.Tag profile = maybeProfile.get();
-
-                    t = (Xml.Tag) new RemoveContentVisitor(profile, false, false).visitNonNull(t, ctx, getCursor().getParentOrThrow());
-
+                    Xml.Tag existing = maybeProfile.get();
+                    if (SemanticallyEqual.areEqual(existing, profileTag)) {
+                        return t;
+                    }
+                    t = (Xml.Tag) new RemoveContentVisitor(existing, false, false).visitNonNull(t, ctx, getCursor().getParentOrThrow());
                 }
-                Xml.Tag profileTag = Xml.Tag.build("<profile>\n" +
-                                                   "<id>" + id + "</id>\n" +
-                                                   (activation != null ? activation.trim() + "\n" : "") +
-                                                   (properties != null ? properties.trim() + "\n" : "") +
-                                                   (build != null ? build.trim() + "\n" : "") +
-                                                   "</profile>");
                 t = (Xml.Tag) new AddToTagVisitor<>(profiles, profileTag).visitNonNull(t, ctx, getCursor().getParentOrThrow());
 
             }
 
             return t;
         }
+
     }
 }

rewrite-maven/src/test/java/org/openrewrite/maven/AddProfileTest.java

@@ -29,7 +29,7 @@ class AddProfileTest implements RewriteTest {
     @Test
     void addProfileToPom() {
         rewriteRun(
-          spec -> spec.expectedCyclesThatMakeChanges(2).recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
+          spec -> spec.recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
             "<properties><bar>bar</bar></properties>", "<build><param>value</param></build>")),
           pomXml(
             """
@@ -69,7 +69,7 @@ void addProfileToPom() {
     @Test
     void preExistingOtherProfile() {
         rewriteRun(
-          spec -> spec.expectedCyclesThatMakeChanges(2).recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
+          spec -> spec.recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
             "<properties><bar>bar</bar></properties>", "<build><param>value</param></build>")),
           pomXml(
             """
@@ -122,7 +122,7 @@ void preExistingOtherProfile() {
     @Test
     void preExistingMatchingProfile() {
         rewriteRun(
-          spec -> spec.expectedCyclesThatMakeChanges(2).recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
+          spec -> spec.recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
             "<properties><bar>bar</bar></properties>", "<build><param>value</param></build>")),
           pomXml(
             """
@@ -169,6 +169,37 @@ void preExistingMatchingProfile() {
     }
 
 
+    @Test
+    void preExistingIdenticalProfile() {
+        rewriteRun(
+          spec -> spec.recipe(new AddProfile("myprofile", "<activation><foo>foo</foo></activation>",
+            "<properties><bar>bar</bar></properties>", "<build><param>value</param></build>")),
+          pomXml(
+            """
+              <project>
+                <groupId>group</groupId>
+                <artifactId>artifact</artifactId>
+                <version>1</version>
+                <profiles>
+                  <profile>
+                    <id>myprofile</id>
+                    <activation>
+                      <foo>foo</foo>
+                    </activation>
+                    <properties>
+                      <bar>bar</bar>
+                    </properties>
+                    <build>
+                      <param>value</param>
+                    </build>
+                  </profile>
+                </profiles>
+              </project>
+              """
+          )
+        );
+    }
+
     @Test
     void notAPom() {
         rewriteRun(