Fix Substitutions bug

knutwannheden · knutwannheden · commit 28dce26c99cf · 2025-04-10T14:11:46.000+02:00
diff --git a/rewrite-java/src/main/java/org/openrewrite/java/internal/template/Substitutions.java b/rewrite-java/src/main/java/org/openrewrite/java/internal/template/Substitutions.java
@@ -292,6 +292,8 @@ public J visitMethodInvocation(J.MethodInvocation method, Integer integer) {
                 J param = maybeParameter(method.getName());
                 if (param instanceof Expression) {
                     return maybeParenthesize((Expression) param, getCursor());
+                } else if (param != null) {
+                    return param;
                 }
                 return super.visitMethodInvocation(method, integer);
             }
@@ -312,6 +314,8 @@ public J visitLiteral(J.Literal literal, Integer integer) {
                 J param = maybeParameter(literal);
                 if (param instanceof Expression) {
                     return maybeParenthesize((Expression) param, getCursor());
+                } else if (param != null) {
+                    return param;
                 }
                 return super.visitLiteral(literal, integer);
             }

Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,8 @@ public J visitMethodInvocation(J.MethodInvocation method, Integer integer) {`
`292`	`292`	`J param = maybeParameter(method.getName());`
`293`	`293`	`if (param instanceof Expression) {`
`294`	`294`	`return maybeParenthesize((Expression) param, getCursor());`
	`295`	`+ } else if (param != null) {`
	`296`	`+ return param;`
`295`	`297`	`}`
`296`	`298`	`return super.visitMethodInvocation(method, integer);`
`297`	`299`	`}`
`@@ -312,6 +314,8 @@ public J visitLiteral(J.Literal literal, Integer integer) {`
`312`	`314`	`J param = maybeParameter(literal);`
`313`	`315`	`if (param instanceof Expression) {`
`314`	`316`	`return maybeParenthesize((Expression) param, getCursor());`
	`317`	`+ } else if (param != null) {`
	`318`	`+ return param;`
`315`	`319`	`}`
`316`	`320`	`return super.visitLiteral(literal, integer);`
`317`	`321`	`}`