refactor: Remove redundant null checks before instanceof (#5736)

* refactor: Remove redundant null checks before instanceof

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeInstanceof?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <team@moderne.io>

* Apply suggestions from code review

---------

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

rewrite-java/src/main/java/org/openrewrite/java/MethodMatcher.java

@@ -372,8 +372,7 @@ private boolean matchesAllowingUnknownTypes(J.MethodInvocation method) {
             return false;
         }
 
-        if (method.getSelect() != null &&
-            method.getSelect() instanceof J.Identifier &&
+        if (method.getSelect() instanceof J.Identifier &&
             !matchesSelectBySimpleNameAlone(((J.Identifier) method.getSelect()))) {
             return false;
         }

rewrite-java/src/main/java/org/openrewrite/java/cleanup/UnnecessaryParenthesesVisitor.java

@@ -137,7 +137,7 @@ public J visitReturn(J.Return return_, P ctx) {
     @Override
     public J visitVariable(J.VariableDeclarations.NamedVariable variable, P ctx) {
         J.VariableDeclarations.NamedVariable v = (J.VariableDeclarations.NamedVariable) super.visitVariable(variable, ctx);
-        if (getStyle().getAssign() && v.getInitializer() != null && v.getInitializer() instanceof J.Parentheses) {
+        if (getStyle().getAssign() && v.getInitializer() instanceof J.Parentheses) {
             v = (J.VariableDeclarations.NamedVariable) new UnwrapParentheses<>((J.Parentheses<?>) v.getInitializer()).visitNonNull(v, ctx, getCursor().getParentOrThrow());
         }
         return v;

rewrite-java/src/main/java/org/openrewrite/java/tree/J.java

@@ -6182,7 +6182,7 @@ public List<J.Annotation> getAllAnnotations() {
             for (J.Modifier modifier : modifiers) {
                 allAnnotations.addAll(modifier.getAnnotations());
             }
-            if (typeExpression != null && typeExpression instanceof J.AnnotatedType) {
+            if (typeExpression instanceof J.AnnotatedType) {
                 allAnnotations.addAll(((J.AnnotatedType) typeExpression).getAnnotations());
             }
             return allAnnotations;

rewrite-javascript/src/main/java/org/openrewrite/javascript/tree/JS.java

@@ -2318,7 +2318,7 @@ public List<J.Annotation> getAllAnnotations() {
             for (J.Modifier modifier : modifiers) {
                 allAnnotations.addAll(modifier.getAnnotations());
             }
-            if (typeExpression != null && typeExpression instanceof J.AnnotatedType) {
+            if (typeExpression instanceof J.AnnotatedType) {
                 allAnnotations.addAll(((J.AnnotatedType) typeExpression).getAnnotations());
             }
             return allAnnotations;

rewrite-kotlin/src/main/java/org/openrewrite/kotlin/internal/KotlinTreeParserVisitor.java

@@ -3576,7 +3576,7 @@ private J.MethodInvocation mapType(J.MethodInvocation tree) {
 
     private J.NewClass mapType(J.NewClass tree) {
         J.NewClass n = tree;
-        if (n.getClazz() != null && n.getClazz() instanceof J.Identifier) {
+        if (n.getClazz() instanceof J.Identifier) {
             if (n.getClazz().getType() instanceof JavaType.Parameterized) {
                 J.Identifier clazz = (J.Identifier) n.getClazz();
                 n = n.withClazz(clazz.withType(((JavaType.Parameterized) clazz.getType()).getType()));