Avoid traversal when newVersion or compartor is null

Author: timtebeek

rewrite-maven/src/main/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactId.java

@@ -151,20 +151,25 @@ public Accumulator getInitialValue(ExecutionContext ctx) {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getScanner(Accumulator acc) {
+        if (newVersion == null) {
+            return TreeVisitor.noop();
+        }
+        final VersionComparator versionComparator = Semver.validate(newVersion, versionPattern).getValue();
+        if (versionComparator == null) {
+            return TreeVisitor.noop();
+        }
         return new MavenIsoVisitor<ExecutionContext>() {
-            final @Nullable VersionComparator versionComparator = newVersion != null ? Semver.validate(newVersion, versionPattern).getValue() : null;
             final boolean configuredToChangeManagedDependency = changeManagedDependency == null || changeManagedDependency;
 
             @Override
             public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) {
-                if (!isDependencyTag(oldGroupId, oldArtifactId) && !isPluginDependencyTag(oldGroupId, oldArtifactId) && !isAnnotationProcessorPathTag(oldGroupId, oldArtifactId)) {
-                    return super.visitTag(tag, ctx);
-                }
-                if (newVersion == null || versionComparator == null) {
+                if (!isDependencyTag(oldGroupId, oldArtifactId) &&
+                        !isPluginDependencyTag(oldGroupId, oldArtifactId) &&
+                        !isAnnotationProcessorPathTag(oldGroupId, oldArtifactId)) {
                     return super.visitTag(tag, ctx);
                 }
                 String currentVersion = tag.getChildValue("version").orElse(null);
-                if (currentVersion == null || !isProperty(currentVersion)) {
+                if (!isProperty(currentVersion)) {
                     return super.visitTag(tag, ctx);
                 }
                 String propertyName = currentVersion.substring(2, currentVersion.length() - 1);

rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java

@@ -2356,7 +2356,7 @@ void changeVersionPropertyInParentPomSimple() {
                   <artifactId>parent-project</artifactId>
                   <version>1</version>
                   <properties>
-                    <version.swagger>2.2.42</version.swagger>
+                    <version.swagger>2.2.43</version.swagger>
                   </properties>
                   <modules>
                     <module>sub-project</module>
@@ -2493,7 +2493,7 @@ void sharedPropertyInParentPomLeavesPropertyUnchangedAndInlinesVersion() {
                       <dependency>
                         <groupId>io.swagger.core.v3</groupId>
                         <artifactId>swagger-annotations</artifactId>
-                        <version>2.2.42</version>
+                        <version>2.2.43</version>
                       </dependency>
                       <dependency>
                         <groupId>io.swagger</groupId>
@@ -2583,7 +2583,7 @@ void sharedPropertyInParentPomUsedByDifferentChildrenLeavesPropertyUnchanged() {
                       <dependency>
                         <groupId>io.swagger.core.v3</groupId>
                         <artifactId>swagger-annotations</artifactId>
-                        <version>2.2.42</version>
+                        <version>2.2.43</version>
                       </dependency>
                     </dependencies>
                   </project>
@@ -2678,7 +2678,7 @@ void childRedefinesPropertyUsedNonConflictinglyInlinesVersionInParent() {
                     <dependency>
                       <groupId>io.swagger.core.v3</groupId>
                       <artifactId>swagger-annotations</artifactId>
-                      <version>2.2.42</version>
+                      <version>2.2.43</version>
                     </dependency>
                   </dependencies>
                 </project>
@@ -2913,7 +2913,7 @@ void handlesGlobCorrectly() {
             "swagger-*",
             "io.swagger.core.v3",
             null,
-            "2.2.42",
+            "2.2.43",
             null
           )),
           //language=xml
@@ -2951,7 +2951,7 @@ void handlesGlobCorrectly() {
                 <artifactId>demo-child</artifactId>
                 <version>0.0.1-SNAPSHOT</version>
                 <properties>
-                  <version.swagger>2.2.42</version.swagger>
+                  <version.swagger>2.2.43</version.swagger>
                 </properties>
                 <dependencies>
                   <dependency>