RecipeListing withers now preserve metadata map (#6849)

The Lombok-generated @with methods created new instances via the
all-args constructor, which left the metadata map empty. Replace
them with hand-written withMarketplace/withBundle that copy
metadata into the new instance.

Author: jkschneider

rewrite-core/src/main/java/org/openrewrite/marketplace/RecipeListing.java

@@ -33,7 +33,6 @@ public class RecipeListing implements Comparable<RecipeListing> {
     /**
      * The marketplace that this listing belongs to.
      */
-    @With
     private final @Nullable RecipeMarketplace marketplace;
 
     private final @EqualsAndHashCode.Include String name;
@@ -61,9 +60,28 @@ public class RecipeListing implements Comparable<RecipeListing> {
 
     private final Map<String, Object> metadata = new LinkedHashMap<>();
 
-    @With(AccessLevel.PACKAGE)
     private final RecipeBundle bundle;
 
+    public RecipeListing withMarketplace(@Nullable RecipeMarketplace marketplace) {
+        if (this.marketplace == marketplace) {
+            return this;
+        }
+        RecipeListing copy = new RecipeListing(marketplace, name, displayName, description,
+                estimatedEffortPerOccurrence, options, dataTables, recipeCount, bundle);
+        copy.metadata.putAll(this.metadata);
+        return copy;
+    }
+
+    RecipeListing withBundle(RecipeBundle bundle) {
+        if (this.bundle == bundle) {
+            return this;
+        }
+        RecipeListing copy = new RecipeListing(marketplace, name, displayName, description,
+                estimatedEffortPerOccurrence, options, dataTables, recipeCount, bundle);
+        copy.metadata.putAll(this.metadata);
+        return copy;
+    }
+
     private RecipeBundleReader resolve(Collection<RecipeBundleResolver> resolvers) {
         for (RecipeBundleResolver resolver : resolvers) {
             if (resolver.getEcosystem().equals(bundle.getPackageEcosystem())) {

rewrite-core/src/test/java/org/openrewrite/marketplace/RecipeMarketplaceReaderTest.java

@@ -402,6 +402,40 @@ private void setVersionRecursive(RecipeMarketplace.Category category, String pac
         }
     }
 
+    @Test
+    void mergePreservesMetadata() {
+        // Source marketplace has a recipe with metadata in "Java" category
+        RecipeMarketplace source = new RecipeMarketplaceReader().fromCsv("""
+          name,displayName,description,category,ecosystem,packageName,embedding
+          org.example.TestRecipe,Test Recipe,A test recipe,Java,maven,org.example:test,abc123
+          """);
+
+        // Verify metadata was read
+        RecipeListing sourceRecipe = source.getAllRecipes().iterator().next();
+        assertThat(sourceRecipe.getMetadata().get("embedding")).isEqualTo("abc123");
+
+        // Target marketplace also has a recipe in "Java" (overlapping category)
+        RecipeMarketplace target = new RecipeMarketplaceReader().fromCsv("""
+          name,displayName,description,category,ecosystem,packageName,embedding
+          org.example.OtherRecipe,Other Recipe,Another recipe,Java,maven,org.example:other,xyz789
+          """);
+
+        // Merge source into target — both have "Java" category so this exercises
+        // the recursive merge path where withMarketplace() is called
+        target.getRoot().merge(source.getRoot());
+
+        // Verify both recipes exist and metadata is preserved
+        RecipeListing mergedTest = target.findRecipe("org.example.TestRecipe");
+        assertThat(mergedTest).isNotNull();
+        assertThat(mergedTest.getMetadata().get("embedding"))
+          .as("Metadata should be preserved through merge when categories overlap")
+          .isEqualTo("abc123");
+
+        RecipeListing mergedOther = target.findRecipe("org.example.OtherRecipe");
+        assertThat(mergedOther).isNotNull();
+        assertThat(mergedOther.getMetadata().get("embedding")).isEqualTo("xyz789");
+    }
+
     private static RecipeMarketplace.Category findCategory(RecipeMarketplace.Category category, String name) {
         return category.getCategories().stream()
           .filter(c -> c.getDisplayName().equals(name))