Skip to content

Commit 44480f2

Browse files
unique file names for version.txt files
1 parent 19c94ab commit 44480f2

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

rewrite-javascript/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ rpc.*.log
44
/.rewrite
55
/.working-dir
66

7-
src/main/resources/META-INF/version.txt
7+
src/main/resources/META-INF/rewrite-javascript-version.txt

rewrite-javascript/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ fun extractVersionFromJar(): String? {
7272
if (!jarFile.exists()) return null
7373

7474
return zipTree(jarFile).matching {
75-
include("META-INF/version.txt")
75+
include("META-INF/rewrite-javascript-version.txt")
7676
}.singleFile.readText().trim()
7777
}
7878

@@ -129,7 +129,7 @@ val npmBuild = tasks.register<NpmTask>("npmBuild") {
129129
.withPathSensitivity(PathSensitivity.RELATIVE)
130130
outputs.dir(file("rewrite/dist/"))
131131

132-
val versionTxt = file("src/main/resources/META-INF/version.txt")
132+
val versionTxt = file("src/main/resources/META-INF/rewrite-javascript-version.txt")
133133
outputs.file(versionTxt)
134134
doLast {
135135
versionTxt.writeText(datedSnapshotVersion)
@@ -138,7 +138,7 @@ val npmBuild = tasks.register<NpmTask>("npmBuild") {
138138
args = listOf("run", "build")
139139
}
140140

141-
// Because each of these sees version.txt as an input
141+
// Because each of these sees rewrite-javascript-version.txt as an input
142142
listOf("sourcesJar", "processResources", "licenseMain", "assemble").forEach {
143143
tasks.named(it) {
144144
dependsOn(npmBuild)
@@ -240,7 +240,7 @@ tasks.named("publish") {
240240

241241
extensions.configure<LicenseExtension> {
242242
header = file("${rootProject.projectDir}/gradle/msalLicenseHeader.txt")
243-
exclude("**/version.txt")
243+
exclude("**/rewrite-javascript-version.txt")
244244
// includePatterns.addAll(
245245
// listOf("**/*.ts")
246246
// )

rewrite-javascript/src/main/java/org/openrewrite/javascript/rpc/JavaScriptRewriteRpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ public JavaScriptRewriteRpc get() {
333333
recipeInstallDir == null ? null : "--recipe-install-dir=" + recipeInstallDir.toAbsolutePath().normalize()
334334
);
335335
} else {
336-
String version = StringUtils.readFully(getClass().getResourceAsStream("/META-INF/version.txt"));
336+
String version = StringUtils.readFully(getClass().getResourceAsStream("/META-INF/rewrite-javascript-version.txt"));
337337
cmd = Stream.of(
338338
npxPath.toString(),
339339
// For SNAPSHOT versions, assume npm link has been run and don't use --package

rewrite-python/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
src/main/resources/META-INF/version.txt
1+
src/main/resources/META-INF/rewrite-python-version.txt

rewrite-python/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ val pythonVersion: String = if (System.getenv("CI") != null) {
222222
project.version.toString().replace("-SNAPSHOT", ".dev0")
223223
}
224224

225-
// Write version.txt resource so PythonRewriteRpc can pin the pip package version
225+
// Write rewrite-python-version.txt resource so PythonRewriteRpc can pin the pip package version
226226
val generateVersionTxt by tasks.registering {
227227
group = "python"
228-
description = "Generate META-INF/version.txt for RPC version pinning"
228+
description = "Generate META-INF/rewrite-python-version.txt for RPC version pinning"
229229

230-
val versionTxt = file("src/main/resources/META-INF/version.txt")
230+
val versionTxt = file("src/main/resources/META-INF/rewrite-python-version.txt")
231231
inputs.property("version", pythonVersion)
232232
outputs.file(versionTxt)
233233

@@ -401,6 +401,6 @@ val printTestClasspath by tasks.registering {
401401
}
402402

403403
extensions.configure<LicenseExtension> {
404-
exclude("**/version.txt")
404+
exclude("**/rewrite-python-version.txt")
405405
}
406406

rewrite-python/src/main/java/org/openrewrite/python/rpc/PythonRewriteRpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ public PythonRewriteRpc get() {
542542
// version takes precedence. For release/CI builds, always use pipPackagesPath
543543
// to ensure the correct pinned version.
544544
String version = StringUtils.readFully(
545-
PythonRewriteRpc.class.getResourceAsStream("/META-INF/version.txt")).trim();
545+
PythonRewriteRpc.class.getResourceAsStream("/META-INF/rewrite-python-version.txt")).trim();
546546
boolean isDevBuild = version.isEmpty() || version.endsWith(".dev0");
547547
boolean interpreterHasRewrite = isDevBuild && pipPackagesPath != null && canImportRewrite(pythonPath);
548548
boolean usePipPackagesPath = pipPackagesPath != null && !interpreterHasRewrite;

0 commit comments

Comments
 (0)