Commit 50d2b8f
Tim te Beek
Validate checksum HTTP responses and hex input
`Checksum.fromUri()` did not check the HTTP response status before
parsing the body as hex. When a proxy, CDN, or missing endpoint
returned an HTML/XML error page, `fromHex()` threw a cryptic
`NumberFormatException: For input string: "<?"`.
- Check `response.isSuccessful()` in `fromUri()` before parsing
- Trim response body to handle trailing newlines in checksum files
- Validate hex characters in `fromHex()` with a clear error message
- Catch failures in `DistributionInfos.fetchChecksum()` and return
null so the recipe proceeds without checksum verification
Fixes #67621 parent 8c01766 commit 50d2b8f
3 files changed
Lines changed: 23 additions & 3 deletions
File tree
- rewrite-core/src
- main/java/org/openrewrite
- test/java/org/openrewrite
- rewrite-gradle/src/main/java/org/openrewrite/gradle/util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
56 | 66 | | |
57 | 67 | | |
58 | 68 | | |
| |||
83 | 93 | | |
84 | 94 | | |
85 | 95 | | |
86 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
87 | 101 | | |
88 | 102 | | |
89 | 103 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| 51 | + | |
50 | 52 | | |
51 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
52 | 58 | | |
53 | 59 | | |
0 commit comments