ChangeDependencyGroupIdAndArtifactId updates version properties in parent POMs (#6630)

* `ChangeDependencyGroupIdAndArtifactId` updates version properties in parent POMs

Convert `ChangeDependencyGroupIdAndArtifactId` from `Recipe` to
`ScanningRecipe` so that version properties defined in parent POMs
are updated when the dependency referencing that property is in a
child POM.

The scanner phase identifies version properties inherited from parent
POMs and records which source file defines each property. The visitor
phase then applies property updates when visiting those parent POM
files. All existing visitor logic is preserved unchanged, avoiding
the recipe-chaining issues that caused the previous attempt (#5815)
to be reverted.

Fixes moderneinc/customer-requests#1374

* Add test for shared property overlap scenario

Verifies that when a property in a parent POM is shared by multiple
dependencies in a child POM, and only one dependency matches the change
criteria, the property is left unchanged and the version is inlined instead.

* Check sibling modules for overlapping property usage

When a version property in a parent POM is shared by dependencies across
different child modules, changing it would break non-matching siblings.
The existing overlap filter only checked the current module's children
and parent dependencies, but not sibling modules.

Walk up the parent chain and check each parent's children to detect
property usage conflicts in sibling modules. When overlap is found,
the version is inlined instead of updating the shared property.

* Add test documenting conservative behavior for redefined child properties

When a child module redefines a parent property used by a non-matching
dependency, the overlap filter conservatively prevents updating the
parent property. This is safe because ChangePropertyValue via doAfterVisit
does not scope to a single document and would also change the child's
intentional override.

* Avoid traversal when newVersion or compartor is null

* Add an early return after handling property tag

---------

Co-authored-by: Tim te Beek <tim@moderne.io>

Author: MBoegers

rewrite-maven/src/main/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactId.java

@@ -29,9 +29,11 @@
 import org.openrewrite.xml.RemoveContentVisitor;
 import org.openrewrite.xml.tree.Xml;
 
+import java.nio.file.Path;
 import java.util.*;
 
 import static java.util.Collections.max;
+import static java.util.Objects.requireNonNull;
 import static java.util.stream.Collectors.toSet;
 import static org.openrewrite.Validated.required;
 import static org.openrewrite.Validated.test;
@@ -41,7 +43,8 @@
 
 @Value
 @EqualsAndHashCode(callSuper = false)
-public class ChangeDependencyGroupIdAndArtifactId extends Recipe {
+public class ChangeDependencyGroupIdAndArtifactId extends ScanningRecipe<ChangeDependencyGroupIdAndArtifactId.Accumulator> {
+    @EqualsAndHashCode.Exclude
     transient MavenMetadataFailures metadataFailures = new MavenMetadataFailures(this);
 
     @Option(displayName = "Old groupId",
@@ -142,7 +145,110 @@ public Validated<Object> validate() {
     }
 
     @Override
-    public TreeVisitor<?, ExecutionContext> getVisitor() {
+    public Accumulator getInitialValue(ExecutionContext ctx) {
+        return new Accumulator();
+    }
+
+    @Override
+    public TreeVisitor<?, ExecutionContext> getScanner(Accumulator acc) {
+        if (newVersion == null) {
+            return TreeVisitor.noop();
+        }
+        final VersionComparator versionComparator = Semver.validate(newVersion, versionPattern).getValue();
+        if (versionComparator == null) {
+            return TreeVisitor.noop();
+        }
+        return new MavenIsoVisitor<ExecutionContext>() {
+            final boolean configuredToChangeManagedDependency = changeManagedDependency == null || changeManagedDependency;
+
+            @Override
+            public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) {
+                if (!isDependencyTag(oldGroupId, oldArtifactId) &&
+                        !isPluginDependencyTag(oldGroupId, oldArtifactId) &&
+                        !isAnnotationProcessorPathTag(oldGroupId, oldArtifactId)) {
+                    return super.visitTag(tag, ctx);
+                }
+                String currentVersion = tag.getChildValue("version").orElse(null);
+                if (!isProperty(currentVersion)) {
+                    return super.visitTag(tag, ctx);
+                }
+                String propertyName = currentVersion.substring(2, currentVersion.length() - 1);
+                if (getResolutionResult().getPom().getRequested().getProperties().containsKey(propertyName)) {
+                    return super.visitTag(tag, ctx);
+                }
+                // Property is inherited from a parent POM; check if it is safe to change
+                Set<String> safeProperties = getSafeVersionPlaceholdersToChange(oldGroupId, oldArtifactId, ctx);
+                if (!safeProperties.contains(currentVersion)) {
+                    return super.visitTag(tag, ctx);
+                }
+                try {
+                    String groupId = Optional.ofNullable(newGroupId).orElse(tag.getChildValue("groupId").orElse(oldGroupId));
+                    String artifactId = Optional.ofNullable(newArtifactId).orElse(tag.getChildValue("artifactId").orElse(oldArtifactId));
+                    String resolvedVersion = resolveSemverVersion(ctx, groupId, artifactId, currentVersion);
+                    storeParentPomProperty(getResolutionResult().getParent(), propertyName, resolvedVersion, acc);
+                } catch (MavenDownloadingException e) {
+                    return e.warn(tag);
+                }
+                return super.visitTag(tag, ctx);
+            }
+
+            private Set<String> getSafeVersionPlaceholdersToChange(String groupId, String artifactId, ExecutionContext ctx) {
+                MavenResolutionResult result = getResolutionResult();
+                ResolvedPom resolvedPom = result.getPom();
+                Pom requestedPom = resolvedPom.getRequested();
+                Set<String> relevantProperties = requestedPom.getDependencies().stream()
+                        .filter(d -> isProperty(d.getVersion()) &&
+                                matchesGlob(resolvedPom.getValue(d.getGroupId()), groupId) &&
+                                matchesGlob(resolvedPom.getValue(d.getArtifactId()), artifactId))
+                        .map(Dependency::getVersion)
+                        .collect(toSet());
+                relevantProperties = filterPropertiesWithOverlapInDependencies(relevantProperties, groupId, artifactId, requestedPom, resolvedPom, configuredToChangeManagedDependency);
+                relevantProperties = filterPropertiesWithOverlapInChildren(relevantProperties, groupId, artifactId, result, configuredToChangeManagedDependency);
+                relevantProperties = filterPropertiesWithOverlapInParents(relevantProperties, groupId, artifactId, result, configuredToChangeManagedDependency, ctx);
+                // Also check sibling modules for overlapping property usage
+                MavenResolutionResult current = result;
+                while (current.parentPomIsProjectPom()) {
+                    current = requireNonNull(current.getParent());
+                    relevantProperties = filterPropertiesWithOverlapInChildren(relevantProperties, groupId, artifactId, current, configuredToChangeManagedDependency);
+                }
+                return relevantProperties;
+            }
+
+            @SuppressWarnings("ConstantConditions")
+            private String resolveSemverVersion(ExecutionContext ctx, String groupId, String artifactId, @Nullable String currentVersion) throws MavenDownloadingException {
+                if (versionComparator == null) {
+                    return newVersion;
+                }
+                String finalCurrentVersion = currentVersion != null ? currentVersion : newVersion;
+                List<String> availableVersions = new ArrayList<>();
+                MavenMetadata mavenMetadata = metadataFailures.insertRows(ctx, () -> downloadMetadata(groupId, artifactId, ctx));
+                for (String v : mavenMetadata.getVersioning().getVersions()) {
+                    if (versionComparator.isValid(finalCurrentVersion, v)) {
+                        availableVersions.add(v);
+                    }
+                }
+                return availableVersions.isEmpty() ? newVersion : max(availableVersions, versionComparator);
+            }
+
+            private void storeParentPomProperty(@Nullable MavenResolutionResult parent, String propertyName, String newValue, Accumulator acc) {
+                if (parent == null) {
+                    return;
+                }
+                Pom pom = parent.getPom().getRequested();
+                if (pom.getSourcePath() == null) {
+                    return;
+                }
+                if (pom.getProperties().containsKey(propertyName)) {
+                    acc.getPomProperties().add(new PomProperty(pom.getSourcePath(), propertyName, newValue));
+                    return;
+                }
+                storeParentPomProperty(parent.getParent(), propertyName, newValue, acc);
+            }
+        };
+    }
+
+    @Override
+    public TreeVisitor<?, ExecutionContext> getVisitor(Accumulator acc) {
         return new MavenVisitor<ExecutionContext>() {
             @Nullable
             final VersionComparator versionComparator = newVersion != null ? Semver.validate(newVersion, versionPattern).getValue() : null;
@@ -176,6 +282,24 @@ public Xml visitDocument(Xml.Document document, ExecutionContext ctx) {
             @Override
             public Xml visitTag(Xml.Tag tag, ExecutionContext ctx) {
                 Xml.Tag t = (Xml.Tag) super.visitTag(tag, ctx);
+
+                // Update version properties in parent POMs based on scanner results
+                if (isPropertyTag()) {
+                    Path pomSourcePath = getResolutionResult().getPom().getRequested().getSourcePath();
+                    for (PomProperty prop : acc.getPomProperties()) {
+                        if (!prop.getPomFilePath().equals(pomSourcePath) || !prop.getPropertyName().equals(tag.getName())) {
+                            continue;
+                        }
+                        Optional<String> value = tag.getValue();
+                        if (!value.isPresent() || !value.get().equals(prop.getNewValue())) {
+                            doAfterVisit(new ChangeTagValueVisitor<>(tag, prop.getNewValue()));
+                            maybeUpdateModel();
+                        }
+                        break;
+                    }
+                    return t;
+                }
+
                 boolean isOldDependencyTag = isDependencyTag(oldGroupId, oldArtifactId);
                 if (isOldDependencyTag && isNewDependencyPresent) {
                     doAfterVisit(new RemoveContentVisitor<>(tag, true, true));
@@ -303,7 +427,14 @@ private Set<String> getSafeVersionPlaceholdersToChange(String groupId, String ar
                         .collect(toSet());
                 relevantProperties = filterPropertiesWithOverlapInDependencies(relevantProperties, groupId, artifactId, requestedPom, resolvedPom, configuredToChangeManagedDependency);
                 relevantProperties = filterPropertiesWithOverlapInChildren(relevantProperties, groupId, artifactId, result, configuredToChangeManagedDependency);
-                return filterPropertiesWithOverlapInParents(relevantProperties, groupId, artifactId, result, configuredToChangeManagedDependency, ctx);
+                relevantProperties = filterPropertiesWithOverlapInParents(relevantProperties, groupId, artifactId, result, configuredToChangeManagedDependency, ctx);
+                // Also check sibling modules for overlapping property usage
+                MavenResolutionResult current = result;
+                while (current.parentPomIsProjectPom()) {
+                    current = requireNonNull(current.getParent());
+                    relevantProperties = filterPropertiesWithOverlapInChildren(relevantProperties, groupId, artifactId, current, configuredToChangeManagedDependency);
+                }
+                return relevantProperties;
             }
 
 
@@ -327,4 +458,16 @@ private String resolveSemverVersion(ExecutionContext ctx, String groupId, String
             }
         };
     }
+
+    @Value
+    public static class Accumulator {
+        Set<PomProperty> pomProperties = new HashSet<>();
+    }
+
+    @Value
+    public static class PomProperty {
+        Path pomFilePath;
+        String propertyName;
+        String newValue;
+    }
 }