Only add SCM to root POM in UpdateScmFromGitOrigin (#5812) (#7287)

Author: timtebeek

rewrite-maven/src/main/java/org/openrewrite/maven/UpdateScmFromGitOrigin.java

@@ -23,6 +23,7 @@
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.marker.GitProvenance;
+import org.openrewrite.maven.tree.MavenResolutionResult;
 import org.openrewrite.xml.AddToTagVisitor;
 import org.openrewrite.xml.ChangeTagValueVisitor;
 import org.openrewrite.xml.tree.Xml;
@@ -48,7 +49,7 @@ public class UpdateScmFromGitOrigin extends Recipe {
     String displayName = "Update SCM with Git origin";
 
     String description = "Updates or adds the Maven `<scm>` tag based on the Git remote origin. " +
-               "By default, only existing Source Control Management (SCM) sections are updated. Set `addIfMissing` to `true` to also add missing SCM sections.";
+               "By default, only existing Source Control Management (SCM) sections are updated. Set `addIfMissing` to `true` to also add missing SCM sections to root POMs (POMs without a parent element).";
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
@@ -69,6 +70,15 @@ public Xml visitDocument(Xml.Document document, ExecutionContext ctx) {
 
                 if(!document.getRoot().getChild("scm").isPresent()) {
                     if (Boolean.TRUE.equals(addIfMissing)) {
+                        // Only add SCM to root POMs (those without a parent)
+                        boolean hasParent = document.getMarkers()
+                                .findFirst(MavenResolutionResult.class)
+                                .map(mrr -> mrr.getParent() != null)
+                                .orElse(false);
+                        if (hasParent) {
+                            return document;
+                        }
+
                         // Build the SCM tag with all required elements
                         String httpUrl = "https://" + gitOrigin.getHost() + "/" + gitOrigin.getPath();
                         String gitPath = gitOrigin.getPath().endsWith(".git") ?

rewrite-maven/src/test/java/org/openrewrite/maven/UpdateScmFromGitOriginTest.java

@@ -18,12 +18,14 @@
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
+import org.openrewrite.Issue;
 import org.openrewrite.marker.GitProvenance;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
 import java.util.UUID;
 
+import static org.openrewrite.java.Assertions.mavenProject;
 import static org.openrewrite.maven.Assertions.pomXml;
 
 class UpdateScmFromGitOriginTest implements RewriteTest {
@@ -460,6 +462,62 @@ void stillUpdatesExistingScmWhenAddIfMissingIsTrue() {
               )
             );
         }
+
+        @Issue("https://github.com/openrewrite/rewrite/issues/5812")
+        @Test
+        void addsScmToRootPomOnly() {
+            rewriteRun(
+              spec -> spec.recipe(new UpdateScmFromGitOrigin(true)),
+              mavenProject("parent",
+                pomXml(
+                  """
+                    <project>
+                      <modelVersion>4.0.0</modelVersion>
+                      <groupId>com.mycompany.app</groupId>
+                      <artifactId>my-app-parent</artifactId>
+                      <version>1</version>
+                      <packaging>pom</packaging>
+                      <modules>
+                        <module>module1</module>
+                      </modules>
+                    </project>
+                    """,
+                  """
+                    <project>
+                      <modelVersion>4.0.0</modelVersion>
+                      <groupId>com.mycompany.app</groupId>
+                      <artifactId>my-app-parent</artifactId>
+                      <version>1</version>
+                      <packaging>pom</packaging>
+                      <modules>
+                        <module>module1</module>
+                      </modules>
+                      <scm>
+                        <url>https://github.com/example/repo</url>
+                        <connection>scm:git:https://github.com/example/repo.git</connection>
+                        <developerConnection>scm:git:git@github.com:example/repo.git</developerConnection>
+                      </scm>
+                    </project>
+                    """,
+                  spec -> spec.markers(gitProvenance("https://github.com/example/repo.git"))
+                ),
+                mavenProject("module1",
+                  pomXml(
+                    """
+                      <project>
+                        <modelVersion>4.0.0</modelVersion>
+                        <parent>
+                          <groupId>com.mycompany.app</groupId>
+                          <artifactId>my-app-parent</artifactId>
+                          <version>1</version>
+                        </parent>
+                        <artifactId>module1</artifactId>
+                      </project>
+                      """
+                  ))
+              )
+            );
+        }
     }
 
     @Nested